Skip to content

Commit

Permalink
remove the forced waiting on the underlying transport to start up (#5440
Browse files Browse the repository at this point in the history
)

* remove the forced waiting on the underlying transport to start up

* racy spec fix: `BackoffOnRestartSupervisor_must_respect_maxNrOfRetries_property_of_OneForOneStrategy` (#5442)

issue was that using `AutoReset` could cause a race where if the scheduler could reset the count in-flight and throw off the estimates used by the tests. Using a `ManualReset` avoids this issue.

* deleted commented out code

* Make updates to `FishUntil` (#5433)

* Make updates to `FishUntil`

Implement nitpicks from #5430

* Nitpick

* cleaned up `FishUntilMessage`

* removed `FluentAssertions` reference

* fixed bad `TestKit.ReceiveTests`

* Custom frame size computation support in Framing (#5444)

* Custom frame size computation support in Framing

* Speed up of framing spec

* optimize `Props` `NewExpression` allocations (#5428)

per #5416 (comment)

Co-authored-by: Ismael Hamed <[email protected]>
  • Loading branch information
Aaronontheweb and ismaelhamed authored Dec 20, 2021
1 parent 42501db commit a0f4705
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/core/Akka/Actor/Internal/ActorSystemImpl.cs
Original file line number Diff line number Diff line change
Expand Up @@ -225,17 +225,6 @@ public void Start()
{
_log.Info(Settings.ToString());
}

//HACK: ensure provider started
{
if (_provider.DefaultAddress is null)
Thread.Yield();
var i = 1;
while(i < 10 && _provider.DefaultAddress is null)
Thread.Sleep(i++ * 16);
if (i == 10 && _provider.DefaultAddress is null)
throw new TimeoutException($"Provider '{_provider.GetType()}' startup timeout");
}
}
catch (Exception)
{
Expand Down

0 comments on commit a0f4705

Please sign in to comment.