perf: Cache sql construction #522
Conversation
* avoid string concatenation and allocations * since they are now created each time its used due to the data partitions by slice
| @@ -81,4 +82,29 @@ object Sql { | |||
| } | |||
| } | |||
|
|
|||
| final class Cache { | |||
There was a problem hiding this comment.
There is also this mutable.Map.getOrElseUpdate from here - maybe this is more convenient, but I am not sure about the performance implications.
There was a problem hiding this comment.
I think we can use immutable here since there will be no updates after initial population
|
Completed this with caching in all places (where it makes sense) |
| FROM $stateTable WHERE persistence_id = ?""" | ||
| } | ||
| protected def selectStateSql(slice: Int, entityType: String): String = | ||
| sqlCache.get(slice, s"selectStateSql-$entityType") { |
There was a problem hiding this comment.
when reviewing this, the highest risk of mistake (by me) is using the wrong cache key, such as accidentally using the same in several places
yeah, some might be questionable, but some might actually do much more than it looks, like those that create the slice ranges |
|
Let's merge it! |
@johanandren can you sanity check this before I continue?