Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional import of uvloop for Python versions less than 3.12 #798

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conditional import of uvloop for Python versions less than 3.12 #798

merged 1 commit into from
Oct 4, 2023

Conversation

davorrunje
Copy link
Collaborator

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # 797

Type of change

Please delete options that are not relevant.

  • Bug fix (a non-breaking change that resolves an issue)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@davorrunje davorrunje added the bug Something isn't working label Oct 4, 2023
@davorrunje davorrunje self-assigned this Oct 4, 2023
@davorrunje davorrunje linked an issue Oct 4, 2023 that may be closed by this pull request
Bug: Add an optional uvloop dependency for Python 3.12 #797
Closed
@davorrunje davorrunje added dependencies Pull requests that update a dependency file and removed bug Something isn't working labels Oct 4, 2023
@davorrunje davorrunje added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 847b81f Oct 4, 2023
@davorrunje davorrunje deleted the 797-bug-add-an-optional-uvloop-dependency-for-python-312 branch October 4, 2023 12:04
@davorrunje davorrunje mentioned this pull request Oct 4, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternakt sternakt sternakt approved these changes

@Lancetnik Lancetnik Awaiting requested review from Lancetnik

Assignees

@davorrunje davorrunje

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Add an optional uvloop dependency for Python 3.12
2 participants
@davorrunje @sternakt