Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with 3.12 added to CI #790

Closed
wants to merge 6 commits into from
Closed

test with 3.12 added to CI #790

wants to merge 6 commits into from

Conversation

davorrunje
Copy link
Collaborator

@davorrunje davorrunje commented Oct 3, 2023 •
edited
Loading

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • New feature (a non-breaking change that adds functionality)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@davorrunje davorrunje marked this pull request as draft October 3, 2023 08:40
@davorrunje davorrunje self-assigned this Oct 4, 2023
@Jaroslav2001
Copy link
Contributor

Maybe add an optional uvloop dependency?
So far this library does not support python 3.12

MagicStack/uvloop#567

@davorrunje
Copy link
Collaborator Author

Maybe add an optional uvloop dependency? So far this library does not support python 3.12

MagicStack/uvloop#567

Merged #798 and a new version released:

https://github.com/airtai/faststream/releases/tag/0.2.1

@Lancetnik
Copy link
Member

We need to wait aiokafka 3.12 support: aio-libs/aiokafka#928

@Lancetnik Lancetnik linked an issue Nov 21, 2023 that may be closed by this pull request
Add support for 3.12 in CI #814
Closed
@Lancetnik
Copy link
Member

Well, aiokafka supports 3.12 now
https://github.com/aio-libs/aiokafka/releases/tag/v0.9.0

@davorrunje
Copy link
Collaborator Author

davorrunje commented Dec 11, 2023 via email

@davorrunje davorrunje closed this Dec 11, 2023
@davorrunje davorrunje deleted the add-python-3.12-support branch December 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davorrunje davorrunje

Labels
None yet
Projects
FastStream
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for 3.12 in CI
3 participants
@davorrunje @Jaroslav2001 @Lancetnik