Destination Snowflake added integration test for NameTransformer #9065

VitaliiMaltsev · 2021-12-22T19:42:19Z

What

added integration test for NameTransformer

How

🚨 User Impact 🚨

None user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

CLAassistant · 2021-12-22T19:42:25Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…ma-naming

VitaliiMaltsev · 2021-12-22T21:03:06Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1613046791
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1613046791
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

...integration/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java

.../java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationIntegrationTest.java

…ma-naming

VitaliiMaltsev · 2021-12-24T09:12:42Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1618701291
❌ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1618701291
🐛

VitaliiMaltsev · 2021-12-24T12:37:23Z

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1619197039
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1619197039
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

VitaliiMaltsev · 2021-12-24T13:53:32Z

@edgao is it good to merge or something else should be added?

edgao

sorry, yes this looks good!

vmaltsev added 13 commits December 15, 2021 10:45

fix for jdk 17

93d53ac

Merge branch 'master' of github.com:airbytehq/airbyte

ede8d38

Merge branch 'master' of github.com:airbytehq/airbyte

27be3fe

Merge branch 'master' of github.com:airbytehq/airbyte

ca75033

Merge branch 'master' of github.com:airbytehq/airbyte

72ab46f

Merge branch 'master' of github.com:airbytehq/airbyte

aec3384

Merge branch 'master' of github.com:airbytehq/airbyte

7efd5aa

Merge branch 'master' of github.com:airbytehq/airbyte

6a773f9

Merge branch 'master' of github.com:airbytehq/airbyte

fa18537

updated SnowflakeDatabase jdbc connection params

8b92a8d

updated spec.json

dbb2d95

updated spec.json

6378294

added integration test

3b67e96

VitaliiMaltsev requested a review from edgao December 22, 2021 19:42

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 22, 2021

vmaltsev added 2 commits December 22, 2021 21:42

Merge branch 'master' of github.com:airbytehq/airbyte

b0ba37b

Merge branch 'master' into vmaltsev/destination-snowflake-update-sche…

1a113b0

…ma-naming

github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 22, 2021

VitaliiMaltsev temporarily deployed to more-secrets December 22, 2021 19:45 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 19:51 Inactive

fix file name

888df78

VitaliiMaltsev temporarily deployed to more-secrets December 22, 2021 21:01 Inactive

fix file name

3ed9025

VitaliiMaltsev temporarily deployed to more-secrets December 22, 2021 21:04 Inactive

jrhizor temporarily deployed to more-secrets December 22, 2021 21:05 Inactive

edgao reviewed Dec 22, 2021

View reviewed changes

...integration/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java Show resolved Hide resolved

.../java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationIntegrationTest.java Outdated Show resolved Hide resolved

updated integration tests

01fccd9

VitaliiMaltsev temporarily deployed to more-secrets December 23, 2021 10:57 Inactive

vmaltsev added 2 commits December 23, 2021 13:04

updated integration tests

869898c

updated test method name

94adebf

VitaliiMaltsev temporarily deployed to more-secrets December 23, 2021 11:07 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 11:15 Inactive

Merge branch 'master' of github.com:airbytehq/airbyte

fa31a0d

jrhizor temporarily deployed to more-secrets December 23, 2021 12:49 Inactive

vmaltsev added 2 commits December 24, 2021 11:10

Merge branch 'master' of github.com:airbytehq/airbyte

67e0bd6

Merge branch 'master' into vmaltsev/destination-snowflake-update-sche…

a975619

…ma-naming

VitaliiMaltsev temporarily deployed to more-secrets December 24, 2021 09:13 Inactive

jrhizor temporarily deployed to more-secrets December 24, 2021 09:14 Inactive

jrhizor temporarily deployed to more-secrets December 24, 2021 12:39 Inactive

edgao approved these changes Dec 24, 2021

View reviewed changes

VitaliiMaltsev merged commit 88562e7 into master Dec 24, 2021

VitaliiMaltsev deleted the vmaltsev/destination-snowflake-update-schema-naming branch December 24, 2021 15:50

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

karinakuz added connectors/destinations-warehouse connectors/destination/snowflake labels Jan 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Destination Snowflake added integration test for NameTransformer #9065

Destination Snowflake added integration test for NameTransformer #9065

VitaliiMaltsev commented Dec 22, 2021

CLAassistant commented Dec 22, 2021

VitaliiMaltsev commented Dec 22, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited

Loading

edgao left a comment

Destination Snowflake added integration test for NameTransformer #9065

Destination Snowflake added integration test for NameTransformer #9065

Conversation

VitaliiMaltsev commented Dec 22, 2021

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Dec 22, 2021

VitaliiMaltsev commented Dec 22, 2021 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 24, 2021 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 24, 2021 • edited by github-actions bot Loading

VitaliiMaltsev commented Dec 24, 2021 • edited Loading

edgao left a comment

Choose a reason for hiding this comment

VitaliiMaltsev commented Dec 22, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Dec 24, 2021 •

edited

Loading