Destination Snowflake added integration test for NameTransformer (#9065)

* fix for jdk 17 * updated SnowflakeDatabase jdbc connection params * updated spec.json * updated spec.json * added integration test * fix file name * fix file name * updated integration tests * updated integration tests * updated test method name Co-authored-by: vmaltsev <[email protected]>
airbytehq · Dec 24, 2021 · 88562e7 · 88562e7
1 parent 6f4c3d1
commit 88562e7
Show file tree

Hide file tree

Showing 2 changed files with 99 additions and 29 deletions.
diff --git a/...va/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationIntegrationTest.java b/...va/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationIntegrationTest.java
@@ -0,0 +1,99 @@
+/*
+ * Copyright (c) 2021 Airbyte, Inc., all rights reserved.
+ */
+
+package io.airbyte.integrations.destination.snowflake;
+
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.node.ObjectNode;
+import io.airbyte.commons.json.Jsons;
+import io.airbyte.commons.string.Strings;
+import io.airbyte.protocol.models.AirbyteConnectionStatus;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.sql.Connection;
+import java.sql.DriverManager;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.Properties;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class SnowflakeDestinationIntegrationTest {
+  private final SnowflakeSQLNameTransformer namingResolver = new SnowflakeSQLNameTransformer();
+
+  @Test
+  void testCheckFailsWithInvalidPermissions() throws Exception {
+    // TODO(sherifnada) this test case is assumes config.json does not have permission to access the
+    // schema
+    // this connector should be updated with multiple credentials, each with a clear purpose (valid,
+    // invalid: insufficient permissions, invalid: wrong password, etc..)
+    final JsonNode credentialsJsonString = Jsons.deserialize(new String(Files.readAllBytes(Paths.get("secrets/config.json"))));
+    final AirbyteConnectionStatus check = new SnowflakeDestination().check(credentialsJsonString);
+    assertEquals(AirbyteConnectionStatus.Status.FAILED, check.getStatus());
+  }
+
+  @Test
+  public void testInvalidSchemaName() {
+    assertDoesNotThrow(this::syncWithNamingResolver);
+    assertThrows(SQLException.class, this::syncWithoutNamingResolver);
+
+  }
+
+  public void syncWithNamingResolver() throws IOException, SQLException {
+    final JsonNode config = getConfig();
+    final String createSchemaQuery = String.format("CREATE SCHEMA %s", namingResolver.getIdentifier(config.get("schema").asText()));
+    Connection connection =null;
+    try {
+      connection = SnowflakeDatabase.getConnection(config);
+      connection.createStatement().execute(createSchemaQuery);
+    }finally {
+      if (connection != null) {
+        final String dropSchemaQuery = String.format("DROP SCHEMA IF EXISTS %s", namingResolver.getIdentifier(config.get("schema").asText()));
+        connection.createStatement().execute(dropSchemaQuery);
+        connection.close();
+      }
+    }
+  }
+
+  private void syncWithoutNamingResolver() throws SQLException, IOException {
+    JsonNode config = getConfig();
+    String schemaName = config.get("schema").asText();
+    final String createSchemaQuery = String.format("CREATE SCHEMA %s", schemaName);
+
+    try (Connection connection = getConnection(config, false)) {
+      Statement statement = connection.createStatement();
+      statement.execute(createSchemaQuery);
+    }
+  }
+
+  public Connection getConnection(JsonNode config, boolean useNameTransformer) throws SQLException {
+
+    final String connectUrl = String.format("jdbc:snowflake://%s", config.get("host").asText());
+
+    final Properties properties = new Properties();
+
+    properties.put("user", config.get("username").asText());
+    properties.put("password", config.get("password").asText());
+    properties.put("warehouse", config.get("warehouse").asText());
+    properties.put("database", config.get("database").asText());
+    properties.put("role", config.get("role").asText());
+    properties.put("schema", useNameTransformer
+            ? namingResolver.getIdentifier(config.get("schema").asText())
+            : config.get("schema").asText());
+
+    properties.put("JDBC_QUERY_RESULT_FORMAT", "JSON");
+
+    return DriverManager.getConnection(connectUrl, properties);
+  }
+
+  private JsonNode getConfig() throws IOException {
+    final JsonNode config = Jsons.deserialize(new String(Files.readAllBytes(Paths.get("secrets/insert_config.json"))));
+    final String schemaName = "schemaName with whitespace " + Strings.addRandomSuffix("integration_test", "_", 5);
+    ((ObjectNode) config).put("schema", schemaName);
+    return config;
+  }
+}
diff --git a/...egration/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java b/...egration/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java