Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: fix array fields in schema with missed items property #5834

Merged
merged 4 commits into from
Sep 7, 2021

Conversation

yaroslav-dudar
Copy link
Contributor

What

Fixed array fields in schema with missed items property #5563
Enabled discovery test

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 3, 2021
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 3, 2021

after fixing array fields I encountered the same issue as described here #5564 , so I suspect that something wrong with GCS destination. But it should work at least with PostgreSQL destination with which I tested it also

@yaroslav-dudar yaroslav-dudar changed the title bug Source Hubspot: fix array fields in schema with missed items property 🐛 Source Hubspot: fix array fields in schema with missed items property Sep 3, 2021
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 3, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197360203
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197360203

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 08:52 Inactive
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 3, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197394404
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197394404

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 09:04 Inactive
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 3, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197442090
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1197442090

@jrhizor jrhizor temporarily deployed to more-secrets September 3, 2021 09:18 Inactive
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 7, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1209316388
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1209316388

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 12:02 Inactive
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 7, 2021

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1209358960
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1209358960

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 12:14 Inactive
@yaroslav-dudar yaroslav-dudar marked this pull request as ready for review September 7, 2021 12:20
@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented Sep 7, 2021

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1210398595
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1210398595

@jrhizor jrhizor temporarily deployed to more-secrets September 7, 2021 17:32 Inactive
@yaroslav-dudar yaroslav-dudar merged commit 5e3b24f into master Sep 7, 2021
@yaroslav-dudar yaroslav-dudar deleted the yaroslav-dudar/5563 branch September 7, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
5 participants