Skip to content

Commit

Permalink
🐛 Source Hubspot: fix array fields in schema with missed items proper…
Browse files Browse the repository at this point in the history
…ty (#5834)

fixed array schemas in companies
  • Loading branch information
yaroslav-dudar authored Sep 7, 2021
1 parent 91a9a68 commit 5e3b24f
Show file tree
Hide file tree
Showing 8 changed files with 51 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "36c891d9-4bd9-43ac-bad2-10e12756272c",
"name": "Hubspot",
"dockerRepository": "airbyte/source-hubspot",
"dockerImageTag": "0.1.11",
"dockerImageTag": "0.1.13",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/hubspot",
"icon": "hubspot.svg"
}
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
- sourceDefinitionId: 36c891d9-4bd9-43ac-bad2-10e12756272c
name: Hubspot
dockerRepository: airbyte/source-hubspot
dockerImageTag: 0.1.11
dockerImageTag: 0.1.13
documentationUrl: https://docs.airbyte.io/integrations/sources/hubspot
icon: hubspot.svg
- sourceDefinitionId: 95e8cffd-b8c4-4039-968e-d32fb4a69bde
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-hubspot/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ RUN pip install .

ENV AIRBYTE_ENTRYPOINT "/airbyte/base.sh"

LABEL io.airbyte.version=0.1.12
LABEL io.airbyte.version=0.1.13
LABEL io.airbyte.name=airbyte/source-hubspot
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ tests:
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
# discovery: fixme (eugene): contacts schema does not match
# - config_path: "secrets/config.json"
discovery:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
# TODO: permissions error with Workflows stream for Test Account
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"type": ["null", "object"],
"properties": {
"appId": {
"type": ["null", "integer"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"type": ["null", "object"],
"properties": {
"portalId": {
"type": ["null", "integer"]
Expand All @@ -11,17 +11,52 @@
"isDeleted": {
"type": ["null", "boolean"]
},
"additionalDomains": {
"type": ["null", "array"]
},
"stateChanges": {
"type": ["null", "array"]
"type": ["null", "array"],
"items": {
"type": ["null", "object"]
}
},
"additionalDomains": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"mergeAudits": {
"type": ["null", "array"]
"type": ["null", "array"],
"items": {
"type": ["null", "object"],
"properties": {
"mergedCompanyId": {
"type": ["null", "integer"]
},
"canonicalCompanyId": {
"type": ["null", "integer"]
},
"sourceId": {
"type": ["null", "string"]
},
"entityId": {
"type": ["null", "string"]
},
"mergedCompanyName": {
"type": ["null", "string"]
},
"movedProperties": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
}
}
}
},
"contacts": {
"type": ["null", "array"]
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"createdAt": {
"type": ["null", "string"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"type": ["null", "object"],
"properties": {
"objectType": {
"type": ["null", "string"]
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/hubspot.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Several output streams are available from this source:

The connector is restricted by normal Hubspot [rate limitations](https://legacydocs.hubspot.com/apps/api_guidelines).

When connector reads the stream using `API Key` that doesn't have neccessary permissions to read particular stream, like `workflows`, which requires to be enabled in order to be processed, the log message returned to the output and sync operation goes on with other streams available.
When connector reads the stream using `API Key` that doesn't have neccessary permissions to read particular stream, like `workflows`, which requires to be enabled in order to be processed, the log message returned to the output and sync operation goes on with other streams available.

Example of the output message when trying to read `workflows` stream with missing permissions for the `API Key`:
```
Expand Down Expand Up @@ -73,6 +73,7 @@ This connector supports only authentication with API Key. To obtain API key for

| Version | Date | Pull Request | Subject |
| :------ | :-------- | :----- | :------ |
| 0.1.13 | 2021-09-08 | [5834](https://github.com/airbytehq/airbyte/pull/5834) | Fixed array fields without items property in schema |
| 0.1.12 | 2021-09-02 | [5798](https://github.com/airbytehq/airbyte/pull/5798) | Treat empty string values as None for field with format to fix normalization errors |
| 0.1.11 | 2021-08-26 | [5685](https://github.com/airbytehq/airbyte/pull/5685) | Remove all date-time format from schemas |
| 0.1.10 | 2021-08-17 | [5463](https://github.com/airbytehq/airbyte/pull/5463) | Fix fail on reading stream using `API Key` without required permissions |
Expand Down

0 comments on commit 5e3b24f

Please sign in to comment.