🪟 🎨 Show Schema Update Errors to User #18008
Merged
+26
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
suggested changes
Oct 17, 2022
airbyte-webapp/src/components/CreateConnection/TryAfterErrorBlock.tsx
Outdated
Show resolved
Hide resolved
teallarson
force-pushed
the
teal/schema-updates-error-messaging
branch
from
e7da21f to
bed98bc
Compare
teallarson
force-pushed
the
teal/schema-updates-error-messaging
branch
from
b42a80b to
5335d30
Compare
edmundito
approved these changes
Oct 18, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* show schema update error * remove test code * use i18n for error message label and string * update snapshot of create connection * fix intl string parsing * update snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #14096
As of #16748, we started actually throwing in the case that there was an error fetching the source schema.
This PR surfaces the error message string as part of that as well. The prop was always there, it just wasn't being passed in.
How
Pass the schema error message
Recommended reading order
SchemaErrorTryAfterErrorBlock