Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed source schema updates appear successful in the UI #14096

Closed
teallarson opened this issue Jun 23, 2022 · 2 comments · Fixed by #18008
Closed

Failed source schema updates appear successful in the UI #14096

teallarson opened this issue Jun 23, 2022 · 2 comments · Fixed by #18008
Assignees
Labels
area/frontend Related to the Airbyte webapp needs-triage team/platform-move type/bug Something isn't working

Comments

@teallarson
Copy link
Contributor

On the Connection page:

Screen Shot 2022-06-23 at 3 42 32 PM

Currently if there is an error response on the POST when a user clicks "refresh source schema", there is no indication to them. It looks to the user as though the refresh completes successfully with no changes in the Source. When the loading screen is done, the refresh button goes away and there is the "if you save this it overrides things" warning, just like if the refresh had been successful (in the above screenshot, there had been a 500 error in the refresh source schema. the schema shown on the screen does not match the actual source schema as a result of the call failing)

We should surface that there was an error refreshing the schema and treat it as if there had not been a successful schema update (ie: the "refresh source schema" button should be visible).

@teallarson teallarson added type/bug Something isn't working needs-triage area/frontend Related to the Airbyte webapp labels Jun 23, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson
Copy link
Contributor Author

@krishnaglick this seems like it might be reasonable to fold into when we address the "refresh source schema" logic? I don't want to introduce scope creep, but seems like it could be small to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp needs-triage team/platform-move type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants