Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

Merged
merged 8 commits into from
Apr 15, 2022
Merged

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb7a648
fix: use AdAccount('act_{id}') to find account instead of iterating
mdibaiee Apr 6, 2022
baa7e85
Bumped version and add unittests
lazebnyi Apr 14, 2022
7f1624e
Merge branch 'master' into 11750-ad-account
lazebnyi Apr 14, 2022
8558d9d
Fixed unittests
lazebnyi Apr 14, 2022
0ebf33f
Refactored test_find_account unit test
lazebnyi Apr 14, 2022
ed5820f
Merge branch 'master' into 11750-ad-account
alafanechere Apr 15, 2022
555c5ad
update source definitions
alafanechere Apr 15, 2022
93d72be
update source definitions
alafanechere Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,7 @@ def account(self) -> AdAccount:
def _find_account(account_id: str) -> AdAccount:
"""Actual implementation of find account"""
try:
accounts = fb_user.User(fbid="me").get_ad_accounts()
for account in accounts:
if account["account_id"] == account_id:
return account
return AdAccount(f"act_{account_id}")
except FacebookRequestError as exc:
lazebnyi marked this conversation as resolved.
Show resolved Hide resolved
raise FacebookAPIException(f"Error: {exc.api_error_code()}, {exc.api_error_message()}") from exc

raise FacebookAPIException("Couldn't find account with id {}".format(account_id))