🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

mdibaiee · 2022-04-06T09:03:43Z

resolves #11750

What

Solves Source Facebook Marketing: find_account method does not work on privacy filtered accounts #11750

How

Instead of iterating over accounts in the list of AdAccounts, directly initialise an AdAccount with the given ID

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

resolves airbytehq#11750

CLAassistant · 2022-04-06T09:04:35Z

All committers have signed the CLA.

alafanechere · 2022-04-13T16:42:35Z

Thank you for your contribution @mdibaiee. As this connector has the General Availability status we need our connector team to give a review. I'm going to run the acceptance test first.

alafanechere · 2022-04-13T16:42:49Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2162548412
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2162548412
🐛 https://gradle.com/s/pbsghlj4yb4ws

alafanechere

@mdibaiee could you please update/create the unit tests related to the function you updated?

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/api.py

lazebnyi · 2022-04-14T10:17:10Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2166602296
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2166602296
🐛 https://gradle.com/s/zehvtqrzwvufu
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
=================== 1 failed, 21 passed in 609.51s (0:10:09) ===================

lazebnyi · 2022-04-14T12:42:13Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2167247235
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2167247235
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/base_streams.py             127     27    79%
source_facebook_marketing/streams/common.py                    41     13    68%
source_facebook_marketing/streams/streams.py                   97     32    67%
source_facebook_marketing/source.py                            39     16    59%
source_facebook_marketing/streams/base_insight_streams.py     129     54    58%
source_facebook_marketing/streams/async_job.py                204    128    37%
source_facebook_marketing/streams/async_job_manager.py         74     56    24%
-------------------------------------------------------------------------------
TOTAL                                                         844    338    60%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/async_job.py                204      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              33      0   100%
source_facebook_marketing/__init__.py                           2      0   100%
source_facebook_marketing/streams/common.py                    41      1    98%
source_facebook_marketing/source.py                            39      1    97%
source_facebook_marketing/streams/async_job_manager.py         74      3    96%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/streams/base_insight_streams.py     129     13    90%
source_facebook_marketing/streams/streams.py                   97     22    77%
source_facebook_marketing/streams/base_streams.py             127     30    76%
-------------------------------------------------------------------------------
TOTAL                                                         844     79    91%

lazebnyi · 2022-04-14T13:14:31Z

Pls, publish/merge after #11801.

alafanechere · 2022-04-15T07:03:04Z

/publish connector=connectors/source-facebook-marketing auto-bump-version=false

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2171384483
🚀 Successfully published connectors/source-facebook-marketing
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2171384483

alafanechere

Thank you for your contribution @mdibaiee! Ready to merge

… instead of iterating (#11751)

fix: use AdAccount('act_{id}') to find account instead of iterating

eb7a648

resolves airbytehq#11750

github-actions bot added the area/connectors Connector related issues label Apr 6, 2022

octavia-squidington-iii added the community label Apr 6, 2022

alafanechere self-assigned this Apr 12, 2022

alafanechere changed the title ~~fix: use AdAccount('act_{id}') to find account instead of iterating~~ Source facebook-marketing: use AdAccount('act_{id}') to find account instead of iterating Apr 13, 2022

alafanechere suggested changes Apr 13, 2022

View reviewed changes

alafanechere reviewed Apr 13, 2022

View reviewed changes

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/api.py Show resolved Hide resolved

Bumped version and add unittests

baa7e85

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 14, 2022

Merge branch 'master' into 11750-ad-account

7f1624e

lazebnyi changed the title ~~Source facebook-marketing: use AdAccount('act_{id}') to find account instead of iterating~~ 🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating Apr 14, 2022

lazebnyi self-requested a review April 14, 2022 10:36

Fixed unittests

8558d9d

Refactored test_find_account unit test

0ebf33f

lazebnyi approved these changes Apr 14, 2022

View reviewed changes

lazebnyi requested a review from alafanechere April 14, 2022 13:12

alafanechere added 2 commits April 15, 2022 09:01

Merge branch 'master' into 11750-ad-account

ed5820f

update source definitions

555c5ad

update source definitions

93d72be

alafanechere approved these changes Apr 15, 2022

View reviewed changes

alafanechere merged commit e78ed58 into airbytehq:master Apr 15, 2022

octavia-squidington-iii mentioned this pull request Apr 19, 2022

Bump Airbyte version from 0.36.0-alpha to 0.36.1-alpha #12148

Merged

suhomud pushed a commit that referenced this pull request May 23, 2022

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account…

2d85bd9

… instead of iterating (#11751)

mdibaiee deleted the 11750-ad-account branch November 8, 2022 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

mdibaiee commented Apr 6, 2022

CLAassistant commented Apr 6, 2022 •

edited

Loading

alafanechere commented Apr 13, 2022

alafanechere commented Apr 13, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

lazebnyi commented Apr 14, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Apr 14, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Apr 14, 2022

alafanechere commented Apr 15, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

🎉Source Facebook Marketing: use AdAccount('act_{id}') to find account instead of iterating #11751

Conversation

mdibaiee commented Apr 6, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Apr 6, 2022 • edited Loading

alafanechere commented Apr 13, 2022

alafanechere commented Apr 13, 2022 • edited by github-actions bot Loading

alafanechere left a comment

Choose a reason for hiding this comment

lazebnyi commented Apr 14, 2022 • edited by github-actions bot Loading

lazebnyi commented Apr 14, 2022 • edited by github-actions bot Loading

lazebnyi commented Apr 14, 2022

alafanechere commented Apr 15, 2022 • edited by github-actions bot Loading

alafanechere left a comment

Choose a reason for hiding this comment

CLAassistant commented Apr 6, 2022 •

edited

Loading

alafanechere commented Apr 13, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Apr 14, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Apr 14, 2022 •

edited by github-actions bot

Loading

alafanechere commented Apr 15, 2022 •

edited by github-actions bot

Loading