Source Mailchimp: unit tests #11632

annalvova05 · 2022-03-31T16:09:34Z

What

Close #11288 - Test coverage more than 90%

How

Add unit tests.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

annalvova05 · 2022-03-31T16:17:10Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2072278456
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2072278456
🐛 https://gradle.com/s/inpc7wemmu3ws

annalvova05 · 2022-03-31T18:22:04Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2072870347
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2072870347
🐛 https://gradle.com/s/454jqihspagvk

annalvova05 · 2022-04-01T06:12:43Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2075493195
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2075493195
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        45      1    98%
source_mailchimp/streams.py      103      7    93%
--------------------------------------------------
TOTAL                            150      8    95%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 38 passed, 1 skipped in 1467.96s (0:24:27) ==================

airbyte-integrations/connectors/source-mailchimp/unit_tests/test_streams.py

airbyte-integrations/connectors/source-mailchimp/unit_tests/test_source.py

airbyte-integrations/connectors/source-mailchimp/unit_tests/test_streams.py

airbyte-integrations/connectors/source-mailchimp/unit_tests/utils.py

annalvova05 · 2022-04-01T11:15:30Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2076922576
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2076922576
🐛 https://gradle.com/s/bpkjm464olzhg
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 37 passed, 1 skipped in 1566.33s (0:26:06) =============

codecov · 2022-04-01T11:21:42Z

Codecov Report

❗ No coverage uploaded for pull request base (master@2b4ee63). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11632   +/-   ##
=========================================
  Coverage          ?   94.66%           
=========================================
  Files             ?        3           
  Lines             ?      150           
  Branches          ?        0           
=========================================
  Hits              ?      142           
  Misses            ?        8           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4ee63...40b58dc. Read the comment docs.

annalvova05 · 2022-04-01T11:54:44Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2077097671
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2077097671
🐛 https://gradle.com/s/4v5c64nm4uyde
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 37 passed, 1 skipped in 1582.96s (0:26:22) =============

annalvova05 · 2022-04-04T06:26:33Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2088098704
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2088098704
🐛 https://gradle.com/s/5xciaqayo7qsk
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 36 passed, 1 skipped in 1753.20s (0:29:13) =============

annalvova05 · 2022-04-04T07:07:37Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2088261115
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2088261115
🐛 https://gradle.com/s/u5pyujyytai7u
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Timeout >300.0s
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 3 failed, 35 passed, 1 skipped in 1875.59s (0:31:15) =============

annalvova05 · 2022-04-05T09:42:58Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2095316140
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2095316140
🐛 https://gradle.com/s/y4acxnppohm6w
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 36 passed, 1 skipped in 1827.20s (0:30:27) =============

…imp-unit-tests

annalvova05 · 2022-04-05T11:26:39Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2095822207
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2095822207
🐛 https://gradle.com/s/etgydi22rbji6
Python short test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1]
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 2 failed, 36 passed, 1 skipped in 1851.14s (0:30:51) =============

annalvova05 · 2022-04-07T14:28:42Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2109615096
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2109615096
🐛 https://gradle.com/s/kbxsjrvuxmjee
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_oneof_usage[inputs0] - AssertionError: Th...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >300.0s
FAILED test_core.py::TestBasicRead::test_read[inputs1] - Failed: Timeout >300.0s
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 3 failed, 35 passed, 1 skipped in 617.28s (0:10:17) ==============

…imp-unit-tests

annalvova05 · 2022-04-11T14:56:09Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149324269
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149324269
🐛 https://gradle.com/s/si53daewhwzyy
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_oneof_usage[inputs0] - AssertionError: Th...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 37 passed, 1 skipped in 738.61s (0:12:18) ==============

annalvova05 · 2022-04-11T15:37:45Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149572620
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149572620
🐛 https://gradle.com/s/cwaymonvcrfvm
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_oneof_usage[inputs0] - AssertionError: Th...
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 37 passed, 1 skipped in 624.16s (0:10:24) ==============

annalvova05 · 2022-04-11T16:08:00Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149744567
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2149744567
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%
Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        45      1    98%
source_mailchimp/streams.py      103      7    93%
--------------------------------------------------
TOTAL                            150      8    95%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 38 passed, 1 skipped in 615.81s (0:10:15) ===================

midavadim

About utils - read_incremental, read_full_refresh.

In the future please try to avoid such big part of new code in tests. Besides that such test looks like 'integration' kind of test.

midavadim · 2022-04-12T00:11:10Z

This update can be released without Airbyte review

annalvova05 · 2022-04-12T07:22:30Z

/publish connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2153357761
🚀 Successfully published connectors/source-mailchimp
🚀 Auto-bumped version for connectors/source-mailchimp
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/2153357761

annalvova05 added 2 commits March 31, 2022 19:04

add tests

7ef5e51

Merge branch 'master' into alvova/11288-mailchimp-unit-tests

bc784fc

annalvova05 self-assigned this Mar 31, 2022

github-actions bot added the area/connectors Connector related issues label Mar 31, 2022

up

27f93ea

annalvova05 added 4 commits March 31, 2022 19:29

up

a6e202e

add tests

15b0eeb

add test for EmailActivity

30bfe42

upd test requirements

9f63c6a

upd test requirements

89d6389

annalvova05 marked this pull request as ready for review April 1, 2022 06:46

annalvova05 requested review from bazarnov and davydov-d April 1, 2022 06:47

bazarnov approved these changes Apr 1, 2022

View reviewed changes

airbyte-integrations/connectors/source-mailchimp/unit_tests/test_streams.py Outdated Show resolved Hide resolved

davydov-d requested changes Apr 1, 2022

View reviewed changes

upd tests

120026f

annalvova05 requested a review from davydov-d April 1, 2022 11:28

bazarnov approved these changes Apr 1, 2022

View reviewed changes

davydov-d approved these changes Apr 1, 2022

View reviewed changes

format

ee6df7f

mock request for ConnectionError

2a170eb

Merge remote-tracking branch 'origin/master' into alvova/11288-mailch…

a348795

…imp-unit-tests

fix test

8a9e2fb

annalvova05 added 2 commits April 11, 2022 17:27

add timeout

daa89aa

Merge remote-tracking branch 'origin/master' into alvova/11288-mailch…

db2a948

…imp-unit-tests

remove default from spec

0ce47f6

remove enum from oneOf

ebe482d

bump version

ccb252d

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 11, 2022

bump version

d4f2abd

annalvova05 requested a review from midavadim April 11, 2022 16:46

midavadim approved these changes Apr 12, 2022

View reviewed changes

bump version

e9c4c57

annalvova05 temporarily deployed to more-secrets April 12, 2022 07:24 Inactive

auto-bump connector version

40b58dc

octavia-squidington-iii temporarily deployed to more-secrets April 12, 2022 07:46 Inactive

annalvova05 merged commit 686e9ed into master Apr 12, 2022

annalvova05 deleted the alvova/11288-mailchimp-unit-tests branch April 12, 2022 07:54

octavia-squidington-iii mentioned this pull request Apr 12, 2022

Bump Airbyte version from 0.35.65-alpha to 0.35.66-alpha #11920

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Mailchimp: unit tests #11632

Source Mailchimp: unit tests #11632

annalvova05 commented Mar 31, 2022 •

edited

Loading

annalvova05 commented Mar 31, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Mar 31, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 1, 2022 •

edited

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 5, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 5, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 7, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

midavadim left a comment

midavadim commented Apr 12, 2022

annalvova05 commented Apr 12, 2022 •

edited by github-actions bot

Loading

Source Mailchimp: unit tests #11632

Source Mailchimp: unit tests #11632

Conversation

annalvova05 commented Mar 31, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

annalvova05 commented Mar 31, 2022 • edited by github-actions bot Loading

annalvova05 commented Mar 31, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 1, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 1, 2022 • edited by github-actions bot Loading

codecov bot commented Apr 1, 2022 • edited Loading

Codecov Report

annalvova05 commented Apr 1, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 4, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 4, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 5, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 5, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 7, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 11, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 11, 2022 • edited by github-actions bot Loading

annalvova05 commented Apr 11, 2022 • edited by github-actions bot Loading

midavadim left a comment

Choose a reason for hiding this comment

midavadim commented Apr 12, 2022

annalvova05 commented Apr 12, 2022 • edited by github-actions bot Loading

annalvova05 commented Mar 31, 2022 •

edited

Loading

annalvova05 commented Mar 31, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Mar 31, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 1, 2022 •

edited

Loading

annalvova05 commented Apr 1, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 4, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 5, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 5, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 7, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 11, 2022 •

edited by github-actions bot

Loading

annalvova05 commented Apr 12, 2022 •

edited by github-actions bot

Loading