Skip to content

Commit

Permalink
remove default from spec
Browse files Browse the repository at this point in the history
  • Loading branch information
@annalvova05
annalvova05 committed Apr 11, 2022
1 parent db2a948 commit 0ce47f6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-mailchimp/source_mailchimp/spec.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"type": "string",
"const": "oauth2.0",
"enum": ["oauth2.0"],
"default": "oauth2.0",
"order": 0
},
"client_id": {
Expand Down Expand Up @@ -52,7 +51,6 @@
"type": "string",
"const": "apikey",
"enum": ["apikey"],
"default": "apikey",
"order": 1
},
"apikey": {
Expand Down

1 comment on commit 0ce47f6

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Source Mailchimp(#11632)

Measures

Name Value Name Value Name Value
Quality Gate Status OK Bugs 0 Lines to Cover 153
Vulnerabilities 0 Lines of Code 167 Reliability Rating A
Coverage 92.8 Duplicated Blocks 0 Duplicated Lines (%) 0.0
Security Rating A Code Smells 15 Blocker Issues 0
Critical Issues 0 Major Issues 3 Minor Issues 12

Detected Issues

Rule File Description Message
python:mypy_import (MINOR) source_mailchimp/source.py:9 Require that imported module can be found or has stubs Library stubs not installed for "requests" (or incompatible with Python 3.7) . Code line: import requests
python:mypy_import (MINOR) source_mailchimp/source.py:14 Require that imported module can be found or has stubs Library stubs not installed for "requests.auth" (or incompatible with Python 3.7) . Code line: from requests.auth import AuthBase
python:mypy_no_any_return (MINOR) source_mailchimp/source.py:26 Reject returning value with "Any" type if return type is not "Any" Returning Any from function declared to return "str" . Code line: return response.json()["dc"]
python:S112 (MAJOR) source_mailchimp/source.py:28 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:S112 (MAJOR) source_mailchimp/source.py:38 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:S112 (MAJOR) source_mailchimp/source.py:50 "Exception" and "BaseException" should not be raised Replace this generic exception class with a more specific one.
python:mypy_assignment (MINOR) source_mailchimp/streams.py:114 Check that assigned value is compatible with target Incompatible types in assignment (expression has type "None", base class "MailChimpStream" defined the type as "str") . Code line: primary_key = None
python:mypy_import (MINOR) source_mailchimp/streams.py:10 Require that imported module can be found or has stubs Library stubs not installed for "requests" (or incompatible with Python 3.7) . Code line: import requests
python:mypy_type_var (MINOR) source_mailchimp/streams.py:82 Check that type variable values are valid Value of type variable "SupportsRichComparisonT" of "max" cannot be "Optional[Any]" . Code line: return {self.cursor_field: max(latest_state, current_state)}
python:mypy_index (MINOR) source_mailchimp/streams.py:122 Check indexing operations Value of type "Optional[Mapping[str, Any]]" is not indexable . Code line: campaign_id = stream_slice["campaign_id"]
python:mypy_arg_type (MINOR) source_mailchimp/streams.py:133 Check argument types in calls Argument 1 to "get" of "Mapping" has incompatible type "Optional[Any]"; expected "str" . Code line: current_state = current_stream_state.get(campaign_id) if curre...
python:mypy_type_var (MINOR) source_mailchimp/streams.py:137 Check that type variable values are valid Value of type variable "SupportsRichComparisonT" of "max" cannot be "Optional[Any]" . Code line: max_value = max(current_state_value, latest_cursor_value)
python:mypy_index (MINOR) source_mailchimp/streams.py:140 Check indexing operations Invalid index type "Optional[Any]" for "MutableMapping[str, Any]"; expected type "str" . Code line: current_stream_state[campaign_id] = new_value
python:mypy_override (MINOR) source_mailchimp/streams.py:143 Check that method override is compatible with base class Signature of "request_params" incompatible with supertype "MailChimpStream" . Code line: def request_params(self, stream_state=None, stream_slice: Mapping[...
python:mypy_index (MINOR) source_mailchimp/streams.py:147 Check indexing operations Value of type "Optional[Mapping[str, Any]]" is not indexable . Code line: since_value_camp = stream_state.get(stream_slice["campaign_id"...

Coverage (92.8%)

File Coverage File Coverage
source_mailchimp/init.py 100.0 source_mailchimp/models/init.py 0.0
source_mailchimp/models/mailchimp.py 0.0 source_mailchimp/source.py 97.8
source_mailchimp/streams.py 93.2

Please sign in to comment.