JDBC sources: update for sources that not have permissions issues #10173

sashaNeshcheret · 2022-02-08T08:01:13Z

What

In scope of #9875 was updated logic related to fetching tables during discovery, it does not work for some connectors and we revert this logic

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

sashaNeshcheret · 2022-02-08T08:02:16Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1811016578
❌ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1811016578
🐛 https://gradle.com/s/dgryuh3dqiciu

sashaNeshcheret · 2022-02-08T08:02:27Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1811017697
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1811017697
No Python unittests run

…e permitted table

sashaNeshcheret · 2022-02-08T10:47:51Z

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1811785930
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1811785930
No Python unittests run

sashaNeshcheret · 2022-02-08T10:48:03Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1811786531
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1811786531
No Python unittests run

sashaNeshcheret · 2022-02-08T10:48:39Z

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1811789404
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1811789404
No Python unittests run

sashaNeshcheret · 2022-02-08T10:49:00Z

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1811791367
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1811791367
No Python unittests run

…e permitted table

alexandr-shegeda

LGTM. we can proceed with publishing without airbyte review

sashaNeshcheret · 2022-02-09T11:06:32Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1817654978
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/1817654978

sashaNeshcheret · 2022-02-09T11:07:01Z

/publish connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1817656942
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1817656942

sashaNeshcheret · 2022-02-09T11:27:36Z

/publish connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1817751812
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1817751812

sashaNeshcheret · 2022-02-09T11:40:12Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817803422
❌ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817803422

sashaNeshcheret · 2022-02-09T11:40:22Z

/publish connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817804155
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817804155

sashaNeshcheret · 2022-02-09T11:41:00Z

/publish connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817806745
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817806745

sashaNeshcheret · 2022-02-09T11:55:11Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817861515
❌ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1817861515

…pdate-for-sources-without-permissions

sashaNeshcheret · 2022-02-09T13:45:23Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1818371803
❌ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1818371803

sashaNeshcheret · 2022-02-09T16:29:51Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1819212916
❌ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1819212916

…rict-encrypt

JDBC sources: update for sources that not have permissions issues

c0ee565

github-actions bot added the area/connectors Connector related issues label Feb 8, 2022

sashaNeshcheret temporarily deployed to more-secrets February 8, 2022 08:02 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 8, 2022 08:04 Inactive

Postgres, CockroachDB and DB2 sources: updated case when user has non…

c4b485a

…e permitted table

sashaNeshcheret temporarily deployed to more-secrets February 8, 2022 10:48 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 8, 2022 10:50 Inactive

sashaNeshcheret linked an issue Feb 8, 2022 that may be closed by this pull request

Improve discovery process for user without permissions to avoid fetching not permitted schemas and tables #10178

Closed

Postgres, CockroachDB and DB2 sources: updated case when user has non…

9622c49

…e permitted table

sashaNeshcheret temporarily deployed to more-secrets February 8, 2022 14:56 Inactive

Postgres, CockroachDB and DB2 sources: bump versions

7226903

sashaNeshcheret requested review from mkhokh-33 and VitaliiMaltsev February 8, 2022 16:25

mkhokh-33 approved these changes Feb 8, 2022

View reviewed changes

github-actions bot added the area/documentation Improvements or additions to documentation label Feb 8, 2022

sashaNeshcheret temporarily deployed to more-secrets February 8, 2022 16:41 Inactive

sashaNeshcheret requested a review from alexandr-shegeda February 9, 2022 10:24

alexandr-shegeda approved these changes Feb 9, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:08 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:09 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:30 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:42 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:43 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 11:57 Inactive

sashaNeshcheret added 2 commits February 9, 2022 14:27

Merge remote-tracking branch 'origin/master' into omneshcheret/8171-u…

5238cec

…pdate-for-sources-without-permissions

Merge remote-tracking branch 'origin/master' into omneshcheret/8171-u…

d91cf55

…pdate-for-sources-without-permissions

sashaNeshcheret temporarily deployed to more-secrets February 9, 2022 12:30 Inactive

Postgres, CockroachDB and DB2 sources: bump source specs

fa9da26

sashaNeshcheret temporarily deployed to more-secrets February 9, 2022 13:45 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 13:47 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 16:31 Inactive

Postgres, CockroachDB and DB2 sources: revert changes for postgres-st…

a3fc128

…rict-encrypt

sashaNeshcheret temporarily deployed to more-secrets February 9, 2022 17:11 Inactive

sashaNeshcheret merged commit 84d1456 into master Feb 9, 2022

sashaNeshcheret deleted the omneshcheret/8171-update-for-sources-without-permissions branch February 9, 2022 17:23

octavia-squidington-iii mentioned this pull request Feb 9, 2022

Bump Airbyte version from 0.35.26-alpha to 0.35.27-alpha #10234

Merged

tuliren mentioned this pull request Feb 24, 2022

🐛 Source Postgres: cannot retrieve all tables accessible to the user #10649

Closed

leoalmeidasant mentioned this pull request Mar 29, 2022

Schema fetch returning empty on postgres >= 0.4.5 #10548

Closed

tuliren mentioned this pull request May 8, 2022

Failure to discover streams from Postgres source #12635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDBC sources: update for sources that not have permissions issues #10173

JDBC sources: update for sources that not have permissions issues #10173

sashaNeshcheret commented Feb 8, 2022 •

edited

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

alexandr-shegeda left a comment

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

JDBC sources: update for sources that not have permissions issues #10173

JDBC sources: update for sources that not have permissions issues #10173

Conversation

sashaNeshcheret commented Feb 8, 2022 • edited Loading

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 • edited by github-actions bot Loading

alexandr-shegeda left a comment

Choose a reason for hiding this comment

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 9, 2022 • edited by github-actions bot Loading

sashaNeshcheret commented Feb 8, 2022 •

edited

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 8, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading

sashaNeshcheret commented Feb 9, 2022 •

edited by github-actions bot

Loading