Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discovery process for user without permissions to avoid fetching not permitted schemas and tables #10178

Closed
sashaNeshcheret opened this issue Feb 8, 2022 · 0 comments · Fixed by #10173
Assignees
Labels
gl type/bug Something isn't working

Comments

@sashaNeshcheret
Copy link
Contributor

sashaNeshcheret commented Feb 8, 2022

Current Behavior

In db2, cockroachdb and postgres source connectors during discovery we are fetching tables and schemas to which user does not have any permissions.

Expected Behavior

In that case user should not see any tables

Logs

If applicable, please upload the logs from the failing operation.
For sync jobs, you can download the full logs from the UI by going to the sync attempt page and
clicking the download logs button at the top right of the logs display window.

Steps to Reproduce

  1. Use db2, cockroachdb or postgres source
  2. Create user without any select permissions
  3. Run discovery with the user.
  4. All tables are shown.

Are you willing to submit a PR?

Remove this with your answer.

@sashaNeshcheret sashaNeshcheret added type/bug Something isn't working needs-triage labels Feb 8, 2022
@sashaNeshcheret sashaNeshcheret linked a pull request Feb 8, 2022 that will close this issue
40 tasks
@sashaNeshcheret sashaNeshcheret self-assigned this Feb 8, 2022
@sashaNeshcheret sashaNeshcheret moved this to Implementation in progress in GL Roadmap Feb 8, 2022
@sashaNeshcheret sashaNeshcheret moved this from Implementation in progress to In review (internal) in GL Roadmap Feb 8, 2022
@alexandr-shegeda alexandr-shegeda moved this from In review (internal) to Done in GL Roadmap Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gl type/bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant