Add default proguard config for sample app

[rossbacher]

Update AGP to 3.2.0
Update Kotlin to 1.2.51
Include consumer proguard file in every variant
Add default proguard config for sample app
Run Proguard on release build type for sample app

Fixes: #126

[bernaferrari]

Nice work! That Proguard file has some really weird things. I commented on some.

[bernaferrari]

A few more suggestions: you named proguard-project.pro instead of proguard-rules.pro. Also, I counted -dontwarn javax.annotation.** there 3 times.

[rossbacher]

@bernaferrari This is on purpose, I want to make clear that these are project specific rules. The name of the file is not really a problem.

-dontwarn javax.annotation.** is in there multiple times as it is in the different configs I had to copy for okhttp3, moshi and retrofit2. These configs are unchanged on purpose. It is ok to have duplicative config.

[bernaferrari]

Fine. I tried the new configurations on my app that crashes with MvRx. I was able to make it stop crashing with the following configuration:

# Print out the full proguard config used for every build
-printconfiguration build/outputs/fullProguardConfig.pro

# These classes are used via kotlin reflection and the keep might not be required anymore once Progurad supports
# Kotlin reflection directlty.
-keep class kotlin.reflect.jvm.internal.impl.builtins.BuiltInsLoaderImpl
-keep class kotlin.reflect.jvm.internal.impl.load.java.FieldOverridabilityCondition
-keep class kotlin.reflect.jvm.internal.impl.load.java.ErasedOverridabilityCondition
-keep class kotlin.reflect.jvm.internal.impl.load.java.JavaIncompatibilityRulesOverridabilityCondition

# If Companion objects are instantiated via Kotlin reflection and they extend/implement a class that Proguard
# would have removed or inlined we run into trouble as the inheritance is still in the Metadata annoation
# read by Kotlin reflection.
# FIXME Remove if Kotlin reflection is supported by Pro/Dexguard
-if class **$Companion extends **
-keep class <2>
-if class **$Companion implements **
-keep class <2>

# https://medium.com/@AthorNZ/kotlin-metadata-jackson-and-proguard-f64f51e5ed32
-keep class kotlin.Metadata { *; }

# Oddly need to keep that even though Evernote state is not used in the app.
-keepnames class * { @com.evernote.android.state.State *;}

I suggest adding it to the library, since everyone using mvrx+epoxy+proguard will get a crash without it (probably because of reflection), which is not fun.

[rossbacher]

I disagree. The config should be very topical and only contain keep rules for classes in the lib (not for anything it depends on).

This is why this is part of the demo app, but it should not be part of the lib itself.

[bernaferrari]

I think you should at least add on wiki that mvrx crashes without some proguard rules, else this will catch a lot of people on surprise.

[rossbacher]

Well the rules are now in the demo app. But I agree, let me update the README...

[bernaferrari]

If I were you I would probably split in the demo what is necessary for the library and what is necessary for the demo (which include retrofit and okhttp that is independent of mvrx).

…

On Fri, Nov 16, 2018, 22:58 rossbacher ***@***.***> wrote: Well the rules are now in the demo app. But I agree, let me update the README... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#138 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVblaS_epCzHugoRPj29OV6K70A_5zdks5uv18ggaJpZM4Ye4JX> .

[rossbacher]

I also updated the Wiki with a Proguard/Dexguard section here: https://github.com/airbnb/MvRx/wiki#proguarddexguard

[rossbacher]

I think you should at least add on wiki that mvrx crashes without some proguard rules, else this will catch a lot of people on surprise.

Done: https://github.com/airbnb/MvRx/wiki#proguarddexguard

[rossbacher]

I also updated the Wiki with a Proguard/Dexguard section here: https://github.com/airbnb/MvRx/wiki#proguarddexguard

Done.

[bernaferrari]

Great, awesome, thanks!