Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create simple espresso test for proguard config #182

Open
BenSchwab opened this issue Jan 14, 2019 · 0 comments
Open

Create simple espresso test for proguard config #182

BenSchwab opened this issue Jan 14, 2019 · 0 comments

Comments

@BenSchwab
Copy link
Collaborator

To prevent proguard regressions when shipping new MvRx versions, we should have a simple espresso test which launches all screens in the sample app.
@BenSchwab BenSchwab mentioned this issue Jan 14, 2019
Merged
gpeal pushed a commit that referenced this issue Jan 14, 2019
@gpeal
Add new keep rule for MvRxViewModelFactory without JvmStatic and init…
037ab28 
…ialState (#181)

#169 Added a new initialState method and ability to not use @JvmStatic all of these need keep rules.

Closes #176

** Note: Kotlin 1.3+ requires this keep rule as well:

keep class kotlin.reflect.jvm.internal.impl.serialization.deserialization.builtins.BuiltInsLoaderImpl

Per the discussion in #138, this is not a project specific rule, so not including it in the proguard file, but updated wiki to suggest it.

Tested on sample app.

Created #182 to prevent this from the future. Would be a great first task if anyone from the community wants to jump on it :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenSchwab