Add support for animating startPoint and endPoint of radial gradients
#1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Nov 3, 2022
| /// Combines the given keyframe groups of `Keyframe<T>`s into a single keyframe group of of `Keyframe<[T]>`s | ||
| /// - If all of the `KeyframeGroup`s have the exact same animation timing, the keyframes are merged | ||
| /// - Otherwise, the keyframes are manually interpolated at each frame in the animation | ||
| static func combined<T>(_ allGroups: [KeyframeGroup<T>]) -> KeyframeGroup<[T]> |
There was a problem hiding this comment.
These methods were renamed from Keyframes.combinedIfPossible(...) -> KeyframeGroup? to Keyframes.combined(...) -> KeyframeGroup
calda
commented
Nov 3, 2022
| else { | ||
| // If the keyframes don't all share the same timing information, | ||
| // we have to interpolate the value at each individual frame | ||
| return Keyframes.manuallyInterpolated(allGroups, makeCombinedResult: makeCombinedResult) |
There was a problem hiding this comment.
This is the only new logic in this method (previously this was just return nil)
calda
commented
Nov 3, 2022
| return KeyframeGroup(keyframes: combinedKeyframes) | ||
| } | ||
|
|
||
| private static func manuallyInterpolated<CombinedResult>( |
erichoracek
approved these changes
Nov 4, 2022
| /// Combines the given keyframe groups of `Keyframe<T>`s into a single keyframe group of of `Keyframe<[T]>`s | ||
| /// - If all of the `KeyframeGroup`s have the exact same animation timing, the keyframes are merged | ||
| /// - Otherwise, the keyframes are manually interpolated at each frame in the animation | ||
| static func combined<T1, T2, T3, T4, T5, T6, T7, CombinedResult>( |
There was a problem hiding this comment.
Could really use "row polymorphism" for this one! 😂
There was a problem hiding this comment.
please, variadic generics when
calda
added a commit
that referenced
this pull request
Nov 28, 2022
calda
added a commit
that referenced
this pull request
Dec 1, 2022
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for animating the
startPointandendPointof radial gradients. We can do this by combining the two sets of keyframes into a singleKeyframeGroup, manually interpolating them if necessary. Fixes #1762.I took this opportunity to consolidate the manual interpolation functionality into
Keyframes.combined, and also adopt this in most other places where we were usingKeyframeGroup.exactlyOneKeyframe.