Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for animating multiple keyframes for gradient startPoint with the Core Animation renderer #1762

Closed
jorgealegre opened this issue Oct 10, 2022 · 2 comments · Fixed by #1798

Comments

@jorgealegre
Copy link

Hello! I was super excited to see the performance improvements in #1627. Although switching to the newer version of the library and forcing the use of the Core Animation did yield good CPU usage results, there is an animation we use in our project that doesn't render properly.

These are the logs I get in the console when using Core Animation:

Lottie/AnimationView.swift:1046: Assertion failed: Encountered Core Animation compatibility issues while setting up animation:
[shimmering orb rotating -withBlueInFront 4.gradient- vertical flowdown.Gradient Fill 1] The Core Animation rendering engine does not support animating multiple keyframes for gradient startPoint values (due to limitations of Core Animation `CAKeyframeAnimation`s).
[shimmering orb rotating -withBlueInFront 4.mask-flowdown dup.Gradient Fill 1] The Core Animation rendering engine does not support animating multiple keyframes for gradient startPoint values (due to limitations of Core Animation `CAKeyframeAnimation`s).

Which Version of Lottie are you using?

Lottie 3.4.4

Expected Behavior

shield-button-main-thread.mov

Actual Behavior

shield-button-core-animation.mov

Animation JSON

shield-button.json.zip

@calda
Copy link
Member

calda commented Nov 3, 2022

Implemented in #1798, thanks for the report and sample animation!

@jorgealegre
Copy link
Author

@calda Nice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants