Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 5: kernel integration (Address interface) #55

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Step 5: kernel integration (Address interface) #55

merged 1 commit into from
Jan 28, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

See PR 782.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Jan 23, 2019
@aionick aionick mentioned this pull request Jan 23, 2019
Merged
aion-kelvin
aion-kelvin approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@aion-kelvin aion-kelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... just want to call out the fact that others (i.e. Centrys for Desktop Wallet) depend on this code; we might want to let them know there's updates to these interfaces.

@AionJayT AionJayT merged commit 69a60fe into master Jan 28, 2019
@AlexandraRoatis AlexandraRoatis deleted the incremental-pr5 branch February 14, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aion-kelvin aion-kelvin aion-kelvin approved these changes

@AionJayT AionJayT Awaiting requested review from AionJayT

@aionick aionick Awaiting requested review from aionick

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandraRoatis @aion-kelvin @AionJayT