Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 5: kernel integration (database put/delete separation + Address interface) #782

Merged
merged 7 commits into from
Jan 28, 2019
Merged

Step 5: kernel integration (database put/delete separation + Address interface) #782

merged 7 commits into from
Jan 28, 2019

Conversation

aionick
Copy link
Contributor

@aionick aionick commented Jan 18, 2019 •
edited by AlexandraRoatis
Loading

Step 5 in the integration.

This PR is concerned with:

  1. Key-value pairs are no longer interpreted as deleted when zero-byte array values, empty byte arrays or null values are provided. The delete functionality is moved out into its own method that must be called explicitly so that zero-byte arrays can be inserted into the database as values.
  2. The use of the Address interface replaces the AionAddress implementation where possible.

Required submodule updates:

@aionick aionick added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 18, 2019
@aionick aionick added this to the 0.3.3 milestone Jan 18, 2019
@AlexandraRoatis
Copy link
Contributor

will reopen after rebase

@AlexandraRoatis AlexandraRoatis mentioned this pull request Jan 21, 2019
Closed
This was referenced Jan 23, 2019
Merged
Merged
@AlexandraRoatis AlexandraRoatis changed the base branch from incremental-pr3 to master-pre-merge January 23, 2019 19:59
@AlexandraRoatis AlexandraRoatis changed the title Step 5: kernel integration (database) Step 5: kernel integration (database put/delete separation + Address interface) Jan 23, 2019
@AlexandraRoatis AlexandraRoatis removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 23, 2019
AionJayT
AionJayT reviewed Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see big issues. Waiting for other reviewer's comments.

aion-kelvin
aion-kelvin reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@aion-kelvin aion-kelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, looks good overall, just had a few small questions

modAion/src/org/aion/zero/db/AionContractDetailsImpl.java Outdated Show resolved Hide resolved
modAionBase/src/org/aion/base/db/IKeyValueStore.java Outdated Show resolved Hide resolved
modAionImpl/src/org/aion/zero/impl/db/AionRepositoryDummy.java Outdated Show resolved Hide resolved
modDbImpl/src/org/aion/db/generic/TimedDatabase.java Outdated Show resolved Hide resolved
modMcf/src/org/aion/mcf/trie/TrieImpl.java Show resolved Hide resolved
modMcf/src/org/aion/mcf/vm/types/KernelInterfaceForFastVM.java Show resolved Hide resolved
modMcf/src/org/aion/mcf/vm/types/KernelInterfaceForFastVM.java Show resolved Hide resolved
@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Jan 24, 2019
@AlexandraRoatis AlexandraRoatis removed their request for review January 24, 2019 15:51
@AlexandraRoatis AlexandraRoatis self-assigned this Jan 24, 2019
@AlexandraRoatis AlexandraRoatis added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 25, 2019
@AlexandraRoatis AlexandraRoatis removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 28, 2019
@AlexandraRoatis
Copy link
Contributor

I removed the contract details put/remove changes from this PR.

@AionJayT AionJayT merged commit 9c1d35b into master-pre-merge Jan 28, 2019
@AlexandraRoatis AlexandraRoatis deleted the incremental-pr5 branch January 29, 2019 21:15
@AlexandraRoatis AlexandraRoatis mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AionJayT AionJayT AionJayT left review comments

@AlexandraRoatis AlexandraRoatis AlexandraRoatis left review comments

@aion-kelvin aion-kelvin aion-kelvin approved these changes

Assignees

@AlexandraRoatis AlexandraRoatis

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@aionick @AlexandraRoatis @AionJayT @aion-kelvin