0.3.4 final #872
Merged
0.3.4 final #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency from source code to the maven repo
fixed NPE concerns in some classes & format revised
…ependency from source code to the maven repo
… into rearchitect-maven
…ncy from source code to the maven repo
…o dependency from source code to the maven repo
…suitable for distribution is also produced
…ependency from source code to the maven repo
fixed NPE concerns in some classes & format revised
…ncy from source code to the maven repo
…o dependency from source code to the maven repo
Added 'blank-slate' config & genesis for avm testnet
…e AionRepositoryCache
Minor repository refactoring
2.) Allow the balance transfer executing inside the avm
Allow avm executing the balance transfer
- This change causes eth_syncing to report 'done syncing' if the local node is within 1 block of the network best block.
Fix to eth_syncing
FVM contract encoding update
aion-kelvin
approved these changes
Apr 9, 2019
| return new RpcMsg( | ||
| null, | ||
| RpcError.INVALID_REQUEST, | ||
| "Invalid Request " + e + " " + e.getMessage() != null ? e.getMessage() : ""); |
There was a problem hiding this comment.
I think putting e already includes the message that is in e.getMessage()
| LOG.error( | ||
| "ApiAion0.process.getBlocksByLatest exception: [{}]", | ||
| e.getMessage()); | ||
| LOG.error("ApiAion0.process.getBlocksByLatest exception: [{}]", e); |
There was a problem hiding this comment.
Since you the second arg is Exception, I think {} is not needed
AlexandraRoatis
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
It is the PR merge for all the 0.3.4 features to get into master
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):