Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor repository refactoring #861

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Minor repository refactoring #861

merged 2 commits into from
Mar 29, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

@AlexandraRoatis AlexandraRoatis commented Mar 29, 2019

Description

  1. moved AbstractContractDetails to modAionImpl
  2. removed the AbstractRepositoryCache and moved all functionality to AionRepositoryCache

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing tests

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added the enhancement New feature or request label Mar 29, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.4.0 milestone Mar 29, 2019
@AlexandraRoatis AlexandraRoatis self-assigned this Mar 29, 2019
Copy link
Collaborator

@AionJayT AionJayT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AionJayT AionJayT merged commit f2daf59 into master-pre-merge Mar 29, 2019
@AionJayT AionJayT deleted the repo-refactor branch April 1, 2019 15:31
@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants