Step 2: kernel integration (migrate functionality to fvm) #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aionick
requested review from
arajasek,
AlexandraRoatis,
AionJayT and
aion-kelvin
aionick
changed the title
AionJayT
reviewed
Jan 17, 2019
| * Zcash project team. | ||
| * Bitcoinj team. | ||
| */ | ||
|
|
There was a problem hiding this comment.
license header should be removed
aion-kelvin
suggested changes
Jan 17, 2019
| */ | ||
| ImportResult tryToConnectInternal(final AionBlock block, long currTimeSeconds) { | ||
| // TEMPORARY: here to support the ConsensusTest | ||
| public Pair<ImportResult, AionBlockSummary> tryToConnectAndFetchSummary(AionBlock block, long currTimeSeconds) { |
There was a problem hiding this comment.
Let's make a note/Issue/Jira to re-visit this once the critical code has been merged in
| @@ -0,0 +1,39 @@ | |||
| /* | |||
aionick
added
the
wip
- The following classes were moved: TransactionExecutor, AbstractExecutor, FastVmResultCode and FastVmTransactionResult. - This is a step on the way towards achieving the correct dependency relationship between modVM, modFastVM and modPrecompiled.
- As well as its two subclasses - these all existed as a means of injecting the fastvm & precompiled depencies into modVM to get around the dependency inversion going on here. This is now done with.
- IPrecompiledContract is now PrecompiledContract and is now in modPrecompiled. IContractFactory is removed. ExecutionContext and SideEffects have been moved from modVM into the fvm.
- Though it is far from its final place. It is merely here so that the modVM, FastVM, modPrecompiled modules all have their dependencies solved. - Now BulkExecutor in modVM sees FastVM instead of the other way round. - The fastVM and modPrecompiled modules no longer depend on modVM.
- This test checks against only a very basic case, that none of the fundamental results required for network consensus are broken by any changes we are doing.
aionick
force-pushed
the
incremental-pr2
branch
from
103c613 to
349f72f
Compare
aionick
removed
the
wip
AionJayT
approved these changes
Jan 18, 2019
AlexandraRoatis
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 in the kernel integration.
This PR mostly moves classes from the kernel into the fast vm.
A consensus test has been added to check some basic hard-coded hash values that we must also produce to not break consensus. This test will be updated as we go on.