Step 3: kernel integration (TransactionExecutor) #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aionick
requested review from
arajasek,
AlexandraRoatis,
AionJayT and
aion-kelvin
aionick
changed the title
AionJayT
reviewed
Jan 17, 2019
modPrecompiled/test/org/aion/precompiled/contracts/TXHashContractTest.java
Outdated
Show resolved
Hide resolved
AionJayT
requested changes
Jan 17, 2019
aion-kelvin
reviewed
Jan 17, 2019
| @@ -0,0 +1,308 @@ | |||
| /* | |||
| * Copyright (c) 2017-2018 Aion foundation. | |||
| * There is no post-execution work to do for any calls in this class. | ||
| */ | ||
| private PostExecutionWork getPostExecutionWork() { | ||
| return (k, s, t, b) -> { |
There was a problem hiding this comment.
Can fix this later, but I think it would make far more sense to instantiate the PostExecutionWork once at constructor (or static) time and return that instance all the time, instead of instantiating it every time this getter is called.
aionick
added
the
wip
aionick
force-pushed
the
incremental-pr2
branch
from
103c613 to
349f72f
Compare
aionick
force-pushed
the
incremental-pr3
branch
from
b5443eb to
d50c1b6
Compare
aionick
changed the title
aionick
removed
the
wip
AionJayT
approved these changes
Jan 18, 2019
aion-kelvin
approved these changes
Jan 18, 2019
aionick
force-pushed
the
incremental-pr3
branch
from
d50c1b6 to
4bf7677
Compare
- This class anticipates the needs of the BulkExecutor once it eventually starts accepting transactions in bulk. In this case, the bulk transactions and their corresponding contexts and block will all be passed over using this single object.
- This will eventually be in terms of KernelInterface. But now at least all explicit reliance on IRepoCache is removed.
- The BulkExecutor mainly takes care of everything the TransactionExecutor used to do in the finish() method. The TransactionExecutor now uses the KernelInterface to do its checks.
- These tests have been migrated over so that they can use the StandaloneBlockchain to perform their integ tests instead of relying on the TransactionExecutor directly (the functionality they previously depended on is now removed).
- This check is empty currently, it always returns true. But eventually we will need real logic here so that the interface can tell the fastvm that it is calling an Avm contract and to fail.
aionick
force-pushed
the
incremental-pr3
branch
from
4bf7677 to
09472b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 3 in the kernel integration.
This PR is mostly concerned with the interplay between the
BulkExecutorandTransactionExecutor. The latter was formerly in modVM and has been moved to the fvm and the former has inherited some of its logic. This is part of the move towards separating these module dependencies out. Some tests have been migrated in the process.