Support "pending" parameter for Web3 getTransactionCount #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AionJayT
reviewed
Nov 6, 2018
|
Added a testcase. This test should be moved into the new file created by PR #691 when that is merged. |
aion-kelvin
approved these changes
Nov 6, 2018
AionJayT
approved these changes
Nov 6, 2018
AlexandraRoatis
approved these changes
Nov 6, 2018
arajasek
force-pushed
the
getTxsCountPending
branch
from
5533507 to
a91ff23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.
Description
The ethereum Web3 allows most functions that take a block number as parameter to also take the special keywords "pending", "latest", or "earliest". The current Web3 implementation of getTransactionCount errors out if it is called with "pending".
Note: It might be important to go through the other Web3 functions that take a block number as a parameter and make sure we support these 3 special parameters.
Fixes Issue #695.
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Manually tested that the Web3 API now correctly responds to requests such as
eth.getTransactionCount("address", "pending").then(console.log)Verification
Insert x into the following checkboxes to confirm (eg. [x]):