Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for ApiWeb3Aion #691

Closed
wants to merge 2 commits into from
Closed

Conversation

beidouz
Copy link
Contributor

@beidouz beidouz commented Nov 2, 2018

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Adding tests for ApiWeb3Aion
  • Moved some eth tests from ApiAionTest to ApiWeb3AionTest

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@beidouz beidouz added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Nov 2, 2018
@beidouz beidouz force-pushed the test-modApiServer branch 3 times, most recently from 77d05b9 to d56274b Compare November 7, 2018 19:13
@beidouz beidouz closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant