-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid caching the constructed URL when altering the query string #1436
Conversation
When a query string is passed, the hit rate on the cache goes way down. Its best not to cache the query calls because the data is far more likely to change for query values
CodSpeed Performance ReportMerging #1436 will degrade performances by 24.96%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1436 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 31 31
Lines 5873 5876 +3
Branches 349 349
=======================================
+ Hits 5645 5648 +3
Misses 202 202
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Once its primed the miss rate barely increases now. |
When a query string is passed, the hit rate on the cache goes way down. Its best not to cache the query calls because the data is far more likely to change for query values.
This will show a reduction on the benchmark but its no different than it was before #1434