Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include port in the fast path for building the network location #1284

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 15, 2024

Followup to #1271

We can include port in the fast path as well do avoid doing a full netloc assemble when we know the username and password are None

Copy link

codspeed-hq bot commented Oct 15, 2024

CodSpeed Performance Report

Merging #1284 will not alter performance

Comparing fast_path_include_port (fac96c8) with master (4a5d9fc)

Summary

✅ 49 untouched benchmarks

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (4a5d9fc) to head (fac96c8).
Report is 162 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1284   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files          27       27           
  Lines        5207     5207           
  Branches      305      305           
=======================================
  Hits         4989     4989           
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.81% <100.00%> (ø)
MyPy 44.05% <100.00%> (ø)
OS-Linux 99.29% <83.33%> (-0.05%) ⬇️
OS-Windows 99.34% <83.33%> (-0.06%) ⬇️
OS-macOS 99.00% <83.33%> (-0.05%) ⬇️
Py-3.10.11 98.98% <83.33%> (-0.05%) ⬇️
Py-3.10.15 99.24% <83.33%> (-0.05%) ⬇️
Py-3.11.10 99.24% <83.33%> (-0.05%) ⬇️
Py-3.11.9 98.98% <83.33%> (-0.05%) ⬇️
Py-3.12.7 99.24% <83.33%> (-0.05%) ⬇️
Py-3.13.0 99.24% <83.33%> (-0.05%) ⬇️
Py-3.9.13 98.93% <83.33%> (-0.05%) ⬇️
Py-3.9.20 99.19% <83.33%> (-0.05%) ⬇️
Py-pypy7.3.16 99.24% <83.33%> (-0.06%) ⬇️
Py-pypy7.3.17 99.27% <83.33%> (-0.06%) ⬇️
VM-macos-latest 99.00% <83.33%> (-0.05%) ⬇️
VM-ubuntu-latest 99.29% <83.33%> (-0.05%) ⬇️
VM-windows-latest 99.34% <83.33%> (-0.06%) ⬇️
pytest 99.29% <83.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Oct 15, 2024

Looks to be about a 3% speed up. Cod speed is set to only report changes of 8% or more

@bdraco bdraco changed the title fast path include port Include port in the fast path for building the network location Oct 15, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 15, 2024
@bdraco bdraco force-pushed the fast_path_include_port branch from 9bb134e to fac96c8 Compare October 15, 2024 23:48
@bdraco bdraco marked this pull request as ready for review October 16, 2024 02:17
@bdraco bdraco merged commit 88de6fe into master Oct 16, 2024
42 of 46 checks passed
@bdraco bdraco deleted the fast_path_include_port branch October 16, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant