-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a fast path for URL construction when the netloc is the host #1271
Conversation
CodSpeed Performance ReportMerging #1271 will improve performances by 16.51%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 27 27
Lines 5188 5196 +8
Branches 299 302 +3
=======================================
+ Hits 4966 4974 +8
Misses 195 195
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Connecting to a non-default port, providing a username, or password in the URL is a less likely case. Optimize for the common case.