Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split wheel builds to disable manylinux armv7l wheels #76

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 1, 2024

The image provided by cibuildwheel for manylinux armv7l that was added in 2.22.0 is experimental and not capable of building cffi packages because its missing libcffi-dev

Disable it for now by copying the wheel build config from yarl which splits musllinux and manylinux and already has armv7l manylinux wheels disabled.

Note that we have never built armv7l manylinux wheels so this does not have any impact downstream

The image provided by ciobuildwheel for manylinux armv7l that was
added in 2.22.0 is experimental and not capable of building cffi
packages because its missing libcffi-dev

Disable it for now by copying the wheel build config from yarl
which splits musllinux and manylinux and already has armv7l
manylinux wheels disabled.

Note that we have never built armv7l manylinux wheels so this
does not have any impact downstream
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Dec 1, 2024
Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #76 will not alter performance

Comparing disable_armv7l_manylinux_wheels (a48e5da) with master (08091df)

Summary

✅ 4 untouched benchmarks

@bdraco bdraco merged commit 24fd58a into master Dec 1, 2024
47 checks passed
@bdraco bdraco deleted the disable_armv7l_manylinux_wheels branch December 1, 2024 17:49
@bdraco bdraco mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant