Skip to content

Commit

Permalink
Split wheel builds to disable manylinux armv7l wheels
Browse files Browse the repository at this point in the history
The image provided by ciobuildwheel for manylinux armv7l that was
added in 2.22.0 is experimental and not capable of building cffi
packages because its missing libcffi-dev

Disable it for now by copying the wheel build config from yarl
which splits musllinux and manylinux and already has armv7l
manylinux wheels disabled.

Note that we have never built armv7l manylinux wheels so this
does not have any impact downstream
  • Loading branch information
bdraco committed Dec 1, 2024
1 parent 08091df commit a48e5da
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 4 deletions.
31 changes: 30 additions & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,24 @@ jobs:
- ubuntu
- windows
- macos
tag:
- ''
- 'musllinux'
exclude:
- os: windows
tag: 'musllinux'
- os: macos
tag: 'musllinux'
- os: ubuntu
tag: >-
${{
(github.event_name != 'push' || !contains(github.ref, 'refs/tags/'))
&& 'musllinux' || 'none'
}}
uses: ./.github/workflows/reusable-build-wheel.yml
with:
os: ${{ matrix.os }}
tag: ${{ matrix.tag }}
wheel-tags-to-skip: >-
${{
(github.event_name != 'push' || !contains(github.ref, 'refs/tags/'))
Expand All @@ -144,7 +159,8 @@ jobs:
*-musllinux_*
*-win32
pp*'
|| ''
|| (matrix.tag == 'musllinux') && '*-manylinux_* pp*'
|| '*-musllinux_* pp*'
}}
source-tarball-name: >-
${{ needs.build-pure-python-dists.outputs.sdist-filename }}
Expand Down Expand Up @@ -464,9 +480,22 @@ jobs:
- ppc64le
- s390x
- armv7l
tag:
- ''
- musllinux
exclude:
- tag: ''
qemu: armv7l
uses: ./.github/workflows/reusable-build-wheel.yml
with:
qemu: ${{ matrix.qemu }}
tag: ${{ matrix.tag }}
wheel-tags-to-skip: >-
${{
(matrix.tag == 'musllinux')
&& '*-manylinux_* pp*'
|| '*-musllinux_* pp*'
}}
source-tarball-name: >-
${{ needs.build-pure-python-dists.outputs.sdist-filename }}
dists-artifact-name: ${{ needs.pre-setup.outputs.dists-artifact-name }}
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/reusable-build-wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ on:
default: ''
required: false
type: string
tag:
description: Build platform tag wheels
default: ''
required: false
type: string
source-tarball-name:
description: Sdist filename wildcard
required: true
Expand All @@ -42,7 +47,8 @@ env:
jobs:

build-wheel:
name: Build wheels on ${{ inputs.os }} ${{ inputs.qemu }}
name: >-
Build ${{ inputs.tag }} wheels on ${{ inputs.os }} ${{ inputs.qemu }}
runs-on: ${{ inputs.os }}-latest
timeout-minutes: ${{ inputs.qemu && 60 || 20 }}
steps:
Expand Down Expand Up @@ -83,8 +89,10 @@ jobs:
- name: Upload built artifacts for testing and publishing
uses: actions/upload-artifact@v4
with:
name: >-
${{ inputs.dists-artifact-name }}-${{ inputs.os }}-${{ inputs.qemu }}
name: ${{ inputs.dists-artifact-name }}-
${{ inputs.os }}-
${{ inputs.qemu }}-
${{ inputs.tag }}
path: ./wheelhouse/*.whl

...

0 comments on commit a48e5da

Please sign in to comment.