-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10 and musl
-based runtimes
#629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 93.78% 93.77% -0.02%
==========================================
Files 5 5
Lines 499 498 -1
==========================================
- Hits 468 467 -1
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
musl
-based runtimes
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@webknjaz I've switched our build system to cibuildwheel, works like a charm (after 10+ CI script fixes). Regarding aiohttp: we can publish 3.8 branch without any critical blocker, isn't it? /cc @Dreamsorcerer |
I think we should be good. We recently fixed a couple of missing deprecation errors, so it should be ready for Python 3.10 now. |
Yep. I saw that. Actually, I've been meaning to try it out and have been collaborating with the maintainers a few times in different corners of GH. I think it's great to have. Hope to see it improved even more over time, with Composite Actions that can now invoke other actions.
I haven't checked the automation side of it since I've addressed the CVE in the 3.7 stream. But it should be fine. Except, maybe, we need to check if Towncrier still works as expected — after its recent major release, I've faced a regression in other projects. There is one blocker, though, that is important for my employer. I've even been collaborating with a few people across the company to get the TLS-in-TLS support in aiohttp. My plan was to polish + aio-libs/aiohttp#5992, include this feature in v3.8, and publish it soon (I was actually going to do it around now or in a few days). It'll probably need some warnings in place because of the need to patch CPython and I haven't yet decided on whether to allow a hack in aiohttp directly or try to make it possible to patch it externally — you could actually help with it by seeing python/cpython#28073 through. The team/project should've applied this patch in production today AFAIK but there's a need to get it into upstream properly. They did manual testing but we need to integrate it into our CI — the attempts to do this are currently failing (aio-libs/aiohttp#6002), I haven't figured out why but my suspicion is that it may have something to do with the fact that the proxy library we're trying to integrate is synchronous and it probably needs to be executed in a separate thread 🤷♂️. |
@asvetlov since you're already refactoring some of the publishing aspects, I'll add a few improvements to this branch too:
|
Cool! Regarding release -- I'd like to reuse https://github.com/aio-libs/create-release action for publishing nice-looking GitHub release notes generated from towncrier changelog. The action is usable now. Will do it in a separate PR. |
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`openembedded#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`openembedded#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
-License-Update: Delete the description of the license and use the license address instead. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 5.2.0 (2021-10-03) ===================== Features -------- - 1. Added support Python 3.10 2. Started shipping platform-specific wheels with the ``musl`` tag targeting typical Alpine Linux runtimes. 3. Started shipping platform-specific arm64 wheels for Apple Silicon. (`#629 <https://github.com/aio-libs/multidict/issues/629>`_) Bugfixes -------- - Fixed pure-python implementation that used to raise "Dictionary changed during iteration" error when iterated view (``.keys()``, ``.values()`` or ``.items()``) was created before the dictionary's content change. (`#620 <https://github.com/aio-libs/multidict/issues/620>`_) Signed-off-by: Zang Ruochen <[email protected]> Signed-off-by: Khem Raj <[email protected]> Signed-off-by: Trevor Gamblin <[email protected]>
No description provided.