Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add router.add_get (#986) #990

Closed
wants to merge 2 commits into from
Closed

Add router.add_get (#986) #990

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 23, 2016

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 97.983% when pulling f1160c0 on benmohta:master into 328bb36 on KeepSafe:master.

@asvetlov
Copy link
Member

That's good but please add shortcuts to other methods.

Documentation is also need to be updated.

@coveralls
Copy link

coveralls commented Jul 23, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 97.983% when pulling b9fd1ab on benmohta:master into 328bb36 on KeepSafe:master.

@asvetlov
Copy link
Member

Fixed by #989

@asvetlov asvetlov closed this Jul 24, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @asvetlov