Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #986 - implemented router shortcuts #989

Merged
merged 3 commits into from
Jul 24, 2016
Merged

Resolved #986 - implemented router shortcuts #989

merged 3 commits into from
Jul 24, 2016

Conversation

alexm92
Copy link
Contributor

@alexm92 alexm92 commented Jul 23, 2016

What do these changes do?

Added shortcut methods for router.

Are there changes in behavior for the user?

New methods for adding routes: add_get, add_post, add_put, add_patch, add_delete

Related issue number

#986

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage decreased (-0.06%) to 97.924% when pulling c1b57e1 on alexm92:master into 328bb36 on KeepSafe:master.

@alexm92
Copy link
Contributor Author

alexm92 commented Jul 23, 2016

Hey, did unittest only for add_get, should I do also for other methods? It's copy & pasteing

@asvetlov
Copy link
Member

Having methods which are not test covered is a very bad idea.

Also documentation update is required.

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage increased (+0.005%) to 97.987% when pulling a76e6b7 on alexm92:master into 328bb36 on KeepSafe:master.

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage increased (+0.005%) to 97.987% when pulling 29df274 on alexm92:master into 328bb36 on KeepSafe:master.

@alexm92
Copy link
Contributor Author

alexm92 commented Jul 23, 2016

@asvetlov added other unittests and documentation :)

@asvetlov asvetlov merged commit cfc9c2a into aio-libs:master Jul 24, 2016
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants