Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9885/76b0d734 backport][3.10] Add benchmarks for web middleware #9888

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 14, 2024

This is a backport of PR #9885 as merged into master (76b0d73).

We didn't have any benchmarks that use Middleware, and since we have had some significant slow downs in the past using middleware, we should keep track of this.

@patchback patchback bot requested a review from asvetlov as a code owner November 14, 2024 21:23
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (361db7c) to head (15e8a88).
Report is 119 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9888      +/-   ##
==========================================
+ Coverage   97.78%   97.92%   +0.13%     
==========================================
  Files         108      114       +6     
  Lines       34840    35896    +1056     
  Branches     4164     4324     +160     
==========================================
+ Hits        34070    35151    +1081     
+ Misses        573      553      -20     
+ Partials      197      192       -5     
Flag Coverage Δ
CI-GHA 97.81% <100.00%> (+0.13%) ⬆️
OS-Linux 97.51% <100.00%> (+0.14%) ⬆️
OS-Windows 95.12% <100.00%> (+0.15%) ⬆️
OS-macOS 97.21% <100.00%> (+0.15%) ⬆️
Py-3.10.11 97.07% <100.00%> (+0.02%) ⬆️
Py-3.10.15 97.01% <100.00%> (+0.03%) ⬆️
Py-3.11.10 97.09% <100.00%> (+0.14%) ⬆️
Py-3.11.9 97.14% <100.00%> (+0.10%) ⬆️
Py-3.12.6 ?
Py-3.12.7 97.54% <100.00%> (?)
Py-3.13.0 97.57% <100.00%> (?)
Py-3.8.10 94.52% <100.00%> (+0.03%) ⬆️
Py-3.8.18 96.81% <100.00%> (+0.03%) ⬆️
Py-3.9.13 96.98% <100.00%> (+0.02%) ⬆️
Py-3.9.20 96.96% <100.00%> (+0.06%) ⬆️
Py-pypy7.3.16 96.53% <100.00%> (+0.03%) ⬆️
VM-macos 97.21% <100.00%> (+0.15%) ⬆️
VM-ubuntu 97.51% <100.00%> (+0.14%) ⬆️
VM-windows 95.12% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #9888 will not alter performance

Comparing patchback/backports/3.10/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885 (15e8a88) with 3.10 (e5917cd)

Summary

✅ 24 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885 Change
🆕 test_ten_web_middlewares[pyloop] N/A 44.3 ms N/A

@bdraco bdraco enabled auto-merge (squash) November 14, 2024 21:54
@bdraco bdraco merged commit caaf21b into 3.10 Nov 14, 2024
39 of 40 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885 branch November 14, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant