Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for web middleware #9885

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add benchmarks for web middleware #9885

merged 2 commits into from
Nov 14, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 14, 2024

We didn't have any benchmarks that use Middleware, and since we have had some significant slow downs in the past using middleware, we should keep track of this.

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Nov 14, 2024
@bdraco bdraco requested a review from asvetlov as a code owner November 14, 2024 20:55
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #9885 will not alter performance

Comparing middleware_bench (1935827) with master (a118114)

Summary

✅ 24 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master middleware_bench Change
🆕 test_ten_web_middlewares[pyloop] N/A 38.8 ms N/A

@bdraco bdraco enabled auto-merge (squash) November 14, 2024 21:01
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (a118114) to head (1935827).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9885   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         118      119    +1     
  Lines       36347    36371   +24     
  Branches     4317     4320    +3     
=======================================
+ Hits        35879    35903   +24     
  Misses        315      315           
  Partials      153      153           
Flag Coverage Δ
CI-GHA 98.60% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.28% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.09% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.36% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.22% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.77% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.82% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.27% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 98.35% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.33% <100.00%> (+0.04%) ⬆️
Py-3.9.13 97.14% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.69% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.30% <100.00%> (+<0.01%) ⬆️
VM-macos 97.36% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.28% <100.00%> (+<0.01%) ⬆️
VM-windows 96.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 76b0d73 into master Nov 14, 2024
38 of 39 checks passed
@bdraco bdraco deleted the middleware_bench branch November 14, 2024 21:23
Copy link
Contributor

patchback bot commented Nov 14, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885

Backported as #9888

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 14, 2024
Copy link
Contributor

patchback bot commented Nov 14, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885

Backported as #9889

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 14, 2024

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/76b0d7343837d3e011bd53af8d1c0316b4b73b45/pr-9885

Backported as #9890

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 14, 2024
bdraco added a commit that referenced this pull request Nov 14, 2024
bdraco added a commit that referenced this pull request Nov 14, 2024
bdraco added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants