Add set_content_disposition test #8332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
|
Ah, found |
writer isn't initialised as form-data. |
Dreamsorcerer
added
backport-3.9
backport-3.10
Olegt0rr
commented
Apr 15, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8333 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
(cherry picked from commit 482e6cd)
5 tasks
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8334 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
(cherry picked from commit 482e6cd)
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Apr 15, 2024
…8334) **This is a backport of PR #8332 as merged into master (482e6cd).** Co-authored-by: Oleg A <[email protected]>
Dreamsorcerer
pushed a commit
that referenced
this pull request
Apr 15, 2024
…8333) **This is a backport of PR #8332 as merged into master (482e6cd).** Co-authored-by: Oleg A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add tests, checking
set_content_disposition()case works properlyAre there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Relates #8326
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.