Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8332/482e6cdf backport][3.9] Add set_content_disposition test #8333

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Apr 15, 2024

This is a backport of PR #8332 as merged into master (482e6cd).

What do these changes do?

Add tests, checking set_content_disposition() case works properly

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Relates #8326

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@patchback patchback bot requested review from webknjaz and asvetlov as code owners April 15, 2024 15:59
@patchback patchback bot mentioned this pull request Apr 15, 2024
5 tasks
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (82fbe64) to head (b1607e9).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #8333      +/-   ##
==========================================
+ Coverage   97.33%   97.39%   +0.06%     
==========================================
  Files         108      108              
  Lines       32849    32856       +7     
  Branches     3900     3901       +1     
==========================================
+ Hits        31972    32001      +29     
+ Misses        663      645      -18     
+ Partials      214      210       -4     
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (+0.05%) ⬆️
OS-Linux 96.98% <100.00%> (+0.05%) ⬆️
OS-Windows 94.53% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.65% <100.00%> (+0.08%) ⬆️
Py-3.10.11 94.35% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.76% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.02% <100.00%> (+<0.01%) ⬆️
Py-3.12.2 97.07% <100.00%> (+0.02%) ⬆️
Py-3.8.10 94.32% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.34% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.75% <100.00%> (+0.13%) ⬆️
Py-pypy7.3.15 96.29% <100.00%> (?)
VM-macos 96.65% <100.00%> (+0.08%) ⬆️
VM-ubuntu 96.98% <100.00%> (+0.05%) ⬆️
VM-windows 94.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 7eecdff into 3.9 Apr 15, 2024
33 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/482e6cdf6516607360666a48c5828d3dbe959fbd/pr-8332 branch April 15, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants