Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix: Ignore python internal deprecation warning #6004

Merged
merged 3 commits into from
Sep 18, 2021
+2 −0
Merged

Quick fix: Ignore python internal deprecation warning #6004

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21aa09b
Quick fix: Ignore python internal deprecation warning
Dreamsorcerer Sep 14, 2021
b3b2d00
Update setup.cfg
asvetlov Sep 16, 2021
131fed6
Update setup.cfg
Dreamsorcerer Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ addopts =
filterwarnings =
error
ignore:module 'ssl' has no attribute 'OP_NO_COMPRESSION'. The Python interpreter is compiled against OpenSSL < 1.0.0. Ref. https.//docs.python.org/3/library/ssl.html#ssl.OP_NO_COMPRESSION:UserWarning
ignore:The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.:DeprecationWarning:asyncio.base_events
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment with the explanation right above this line? Maybe with links too. And then, go ahead and merge it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth merging this when it doesn't fix all the tests? Or should we just merge #6006 instead? Or both?

I'll probably just open an issue though to remind myself to revert the changes in a few weeks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if it improves things at least a little, we should merge it. And yes, we could revert later. Plus I'd combine with #6006 too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, you'll need to tweak the required status to get them merged.

junit_suite_name = aiohttp_test_suite
norecursedirs = dist docs build .tox .eggs
minversion = 3.8.2
Expand Down