Quick fix: Ignore python internal deprecation warning #6004
Conversation
Dreamsorcerer
added
the
bot:chronographer:skip
|
Not such a simple fix, as there are tests which assert the number of DeprecationWarnings... |
|
Weird that it doesn't happen in CI unless it's Windows. |
|
@bmbouter what's your CPython version, again? |
Python 3.9.7 |
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
|
Alternative (because this still fails some tests): #6006 |
| @@ -53,6 +53,7 @@ addopts = | |||
| filterwarnings = | |||
| error | |||
| ignore:module 'ssl' has no attribute 'OP_NO_COMPRESSION'. The Python interpreter is compiled against OpenSSL < 1.0.0. Ref. https.//docs.python.org/3/library/ssl.html#ssl.OP_NO_COMPRESSION:UserWarning | |||
| ignore:The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.:DeprecationWarning:asyncio.base_events | |||
There was a problem hiding this comment.
Could you add a comment with the explanation right above this line? Maybe with links too. And then, go ahead and merge it.
There was a problem hiding this comment.
Is it worth merging this when it doesn't fix all the tests? Or should we just merge #6006 instead? Or both?
I'll probably just open an issue though to remind myself to revert the changes in a few weeks.
There was a problem hiding this comment.
I think if it improves things at least a little, we should merge it. And yes, we could revert later. Plus I'd combine with #6006 too.
There was a problem hiding this comment.
Right, you'll need to tweak the required status to get them merged.
A change to deprecation warnings in the last python 3.9 release has resulted in warnings appearing in some internal asyncio code. We'll just ignore them for now (think they are fixed in the next release).
For some bizarre reason, they only seem to happen on Windows though...