Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate route name #567

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Validate route name #567

merged 1 commit into from
Oct 15, 2015

Conversation

Axik
Copy link
Contributor

@Axik Axik commented Oct 15, 2015

Previously route name could take incorrect value with spaces, or numbers at start.
@asvetlov

asvetlov added a commit that referenced this pull request Oct 15, 2015
@asvetlov asvetlov merged commit 4b6ff68 into aio-libs:master Oct 15, 2015
@alexdutton
Copy link
Contributor

Was this an issue? As far as I can tell, they're only ever used with getitem` and not attribute access, so they shouldn't cause any trouble if they contain silly characters.

I'd used colons for namespacing in my route names (e.g. 'oauth2:authorize'), which I would have thought would be reasonable.

@asvetlov
Copy link
Member

Well, initial issue was using just literal text phrases for route names,
which is definitely wrong.
I agree to relax the rule for allowing identifiers separated by dots or
columns.

On Tue, Oct 20, 2015 at 11:41 AM Alexander Dutton [email protected]
wrote:

Was this an issue? As far as I can tell, they're only ever used with
getitem` and not attribute access, so they shouldn't cause any trouble
if they contain silly characters.

I'd used colons for namespacing in my route names (e.g.
'oauth2:authorize'), which I would have thought would be reasonable.


Reply to this email directly or view it on GitHub
#567 (comment).

Thanks,
Andrew Svetlov

@asvetlov
Copy link
Member

Fixed by 0.18.1 release

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants