Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in aiohttp-0.18.0 #32

Closed
avanov opened this issue Oct 20, 2015 · 5 comments
Closed

Breaking change in aiohttp-0.18.0 #32

avanov opened this issue Oct 20, 2015 · 5 comments

Comments

@avanov
Copy link

avanov commented Oct 20, 2015

Related to the following change - aio-libs/aiohttp#567

The version 0.0.5 of the package fails on the following step:
https://github.com/Axik/aiohttp/blob/a2aa20dacbeb34544cc69765e20dabe5718c0d57/aiohttp/web_urldispatcher.py#L448

@asvetlov
Copy link
Member

Please provide an example of name what you use in your code.

@avanov
Copy link
Author

avanov commented Oct 20, 2015

It has to do with the following pre-defined names - https://github.com/aio-libs/aiohttp_debugtoolbar/blob/master/aiohttp_debugtoolbar/main.py#L62-L89 (dot symbols, I suppose).

My app is just using the middleware:

middleware = [aiohttp_debugtoolbar.middleware]
app = web.Application(handler_factory=web.RequestHandlerFactory,
                      middlewares=middleware)
aiohttp_debugtoolbar.setup(app)

@asvetlov
Copy link
Member

Got it. Will publish bugfix release allowing dots and columns today.

@avanov
Copy link
Author

avanov commented Oct 20, 2015

Thanks!

@asvetlov
Copy link
Member

Fixed by aiohttp 0.18.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants