Add support for the no_proxy env var mechanism in the HTTP client
#5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
PR aio-libs#4445 by @scirelli. Fixes aio-libs#4431. Co-authored-by: Steve Cirelli <[email protected]> Co-authored-by: Sviatoslav Sydorenko <[email protected]> (cherry picked from commit 1a4126a)
scirelli
force-pushed
the
backport-1a4126a-3.8
branch
from
86515c8 to
8bc189b
Compare
scirelli
commented
Mar 23, 2021
| else: | ||
| return proxy_info.proxy, proxy_info.proxy_auth | ||
|
|
||
|
|
||
| @attr.s(auto_attribs=True, frozen=True, slots=True) |
There was a problem hiding this comment.
The merge added a @dataclasses.dataclass(frozen=True) here. But since I didn't see it used anywhere else in this file in the 3.8 code I removed it.
|
Hello, I'm also affected by this bug, could this be reviewed soon please? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a backport of #4445
Prior to this patch aiohttp would ignore no_proxy settings.
Are there changes in behavior for the user?
If
no_proxyorNO_PROXYis set, and the request host matches one of the hosts from the no_proxy list, no proxy will be used.Need help in finding where the unit tests go for this.
Related issue number
#4431
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.