Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aca-py not respecting NO_PROXY variables #1403

Closed
paulbastian opened this issue Sep 9, 2021 · 6 comments
Closed

Aca-py not respecting NO_PROXY variables #1403

paulbastian opened this issue Sep 9, 2021 · 6 comments

Comments

@paulbastian
Copy link

Running Aca-py behind company firewalls requires proxy settings, at the same time internal services must be excluded from these proxy routes. Usually this is done by using environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY. Both HTTP_PROXY and HTTPS_PROXY are currently respected by aioHttp and since 0.6.0 imported into aca-py behavior by using the trust_env=True. NO_PROXY is not regarded by aiohttp in the current stable release.
However, the changes have already been merged into aiohttp and shall be released with version 3.8:
aio-libs/aiohttp#5556
Therefore, this is a placeholder and information for people running into the same issue until aioHttp release 3.8 is included into aca-py.
Best regards,
Paul

@paulbastian
Copy link
Author

As a quick fix, you can mount a patched client.py as a volume if working with docker containers:
https://gist.github.com/paulbastian/add8c12cc47509f3b41cb726287e05b5

@webknjaz
Copy link

webknjaz commented Nov 1, 2021

FYI aiohttp v3.8 has been released this night.

@swcurran
Copy link
Contributor

swcurran commented Nov 1, 2021

@shaangill025 -- can you please look at this. Andrew had been on it.

Thanks!

@pstuermlinger
Copy link

pstuermlinger commented May 12, 2022

I'm also running into the same issue. The docker container is configured to use a company proxy. From within the container I can curl to other internal agents and services. However, when Aca-Py 0.7.3 tries to send a message to another local agent via docker host ip (part of no_proxy) it just fails with a "Service Unavailable".

@paulbastian
Copy link
Author

This issue should resolve with version 0.7.4 soon

@pstuermlinger
Copy link

Confirmed, works with the current rc. Thanks!

@swcurran swcurran closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants