Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] switch noop from function to class (#4322) #4712

Merged
merged 1 commit into from
Apr 25, 2020
Merged

[3.6] switch noop from function to class (#4322) #4712

merged 1 commit into from
Apr 25, 2020

Conversation

Jackenmen
Copy link
Contributor

What do these changes do?

They remove the RuntimeWarning for noop function by turning it into class with __await__. It's a backport of #4322 to aiohttp 3.6

Are there changes in behavior for the user?

No

Related issue number

#4282

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@Jackenmen Jackenmen requested a review from asvetlov as a code owner April 25, 2020 22:28
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 25, 2020
@codecov-io
Copy link

codecov-io commented Apr 25, 2020

Codecov Report

Merging #4712 into 3.6 will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.6    #4712      +/-   ##
==========================================
- Coverage   97.96%   97.92%   -0.04%     
==========================================
  Files          44       44              
  Lines        8886     8886              
  Branches     1392     1392              
==========================================
- Hits         8705     8702       -3     
- Misses         72       75       +3     
  Partials      109      109              
Impacted Files Coverage Δ
aiohttp/helpers.py 96.51% <100.00%> (ø)
aiohttp/web_protocol.py 91.34% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dda663...80b69b0. Read the comment docs.

@webknjaz webknjaz merged commit a22acb3 into aio-libs:3.6 Apr 25, 2020
@Jackenmen Jackenmen deleted the fix-4282-3.6-backport branch April 25, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants