switch noop from function to class #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
|
@asvetlov Any ideas about the one test that fails with this change? |
|
The evidence of the mocked test reliability. |
|
Ok, I've removed the test test_data_received_error. I could switch to it being skipped if you want |
Codecov Report
@@ Coverage Diff @@
## master #4322 +/- ##
==========================================
- Coverage 97.55% 97.51% -0.04%
==========================================
Files 43 43
Lines 8862 8862
Branches 1389 1389
==========================================
- Hits 8645 8642 -3
- Misses 93 96 +3
Partials 124 124
Continue to review full report at Codecov.
|
|
Thanks! |
asvetlov
pushed a commit
that referenced
this pull request
Nov 9, 2019
(cherry picked from commit 2ca3c38) Co-authored-by: Adam Bannister <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Nov 9, 2019
* [3.7] switch noop from function to class (#4322) (cherry picked from commit 2ca3c38) Co-authored-by: Adam Bannister <[email protected]>
5 tasks
webknjaz
pushed a commit
that referenced
this pull request
Apr 25, 2020
asvetlov
pushed a commit
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Trying to remove the warning RuntimeWarning: coroutine 'noop' was never awaited that is described in #4282.
Are there changes in behavior for the user?
No
Related issue number
#4282
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.