Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide pytest-aiohttp namespace for pytest fixtures in the doc #4059

Merged
merged 1 commit into from
Sep 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3723.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Provide pytest-aiohttp namespace for pytest fixtures in docs.
5 changes: 5 additions & 0 deletions docs/testing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ proxy methods to the client for common operations such as
Pytest
~~~~~~

.. currentmodule:: pytest_aiohttp

The :data:`aiohttp_client` fixture available from pytest-aiohttp_ plugin
allows you to create a client to make requests to test your app.

Expand Down Expand Up @@ -235,6 +237,9 @@ Pytest tooling has the following fixtures:
Unittest
~~~~~~~~

.. currentmodule:: aiohttp.test_utils

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be two empty lines here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one empty line is enough but sorry, I don't want to wait for CI again before the merge.
Two lines are not such bad.
We have no strong rule for docs, sometimes it has one line as a delimiter but sometimes it has two or even more.


To test applications with the standard library's unittest or unittest-based
functionality, the AioHTTPTestCase is provided::

Expand Down