Provide pytest-aiohttp namespace for pytest fixtures in the doc #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Sep 14, 2019
| @@ -235,6 +237,9 @@ Pytest tooling has the following fixtures: | |||
| Unittest | |||
| ~~~~~~~~ | |||
|
|
|||
| .. currentmodule:: aiohttp.test_utils | |||
|
|
|||
There was a problem hiding this comment.
Should it be two empty lines here?
There was a problem hiding this comment.
Maybe one empty line is enough but sorry, I don't want to wait for CI again before the merge.
Two lines are not such bad.
We have no strong rule for docs, sometimes it has one line as a delimiter but sometimes it has two or even more.
webknjaz
approved these changes
Sep 14, 2019
asvetlov
added a commit
that referenced
this pull request
Sep 15, 2019
…#4059) (cherry picked from commit dc39183) Co-authored-by: Andrew Svetlov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 43 43
Lines 8760 8760
Branches 1373 1373
=======================================
Hits 8561 8561
Misses 85 85
Partials 114 114Continue to review full report at Codecov.
|
asvetlov
added a commit
that referenced
this pull request
Sep 15, 2019
…#4059) (#4061) (cherry picked from commit dc39183) Co-authored-by: Andrew Svetlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3723